[ADD] sale_order_line_effective_date #3129
Open
+791
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
requested changes
May 9, 2024
Comment on lines
+19
to
+22
| moves = line.move_ids.filtered( | ||
| lambda x: x.state == "done" and x.location_dest_id.usage == "customer" | ||
| ) | ||
| dates_list = [date for date in moves.mapped("date") if date] |
There was a problem hiding this comment.
suggestion: filtering twice feels awkward
Suggested change
| moves = line.move_ids.filtered( | |
| lambda x: x.state == "done" and x.location_dest_id.usage == "customer" | |
| ) | |
| dates_list = [date for date in moves.mapped("date") if date] | |
| moves = line.move_ids.filtered( | |
| lambda x: x.state == "done" and x.location_dest_id.usage == "customer" and x.date | |
| ) | |
| dates_list = moves.mapped("date") |
| @@ -0,0 +1 @@ | |||
| This module extends the functionality of sale stock and add field effective date in sale order line, this field is completion date of the first delivery order. | |||
There was a problem hiding this comment.
Suggested change
| This module extends the functionality of sale stock and add field effective date in sale order line, this field is completion date of the first delivery order. | |
| This module extends the functionality of sale stock and adds the field "effective date" in sale order lines. | |
| This field displays the completion date of the first delivery order. |
| To use this module, you need to: | ||
|
|
||
| 1. Go to Sales > Orders > Quotation. | ||
| 1. Create new quotation with storable product. |
There was a problem hiding this comment.
Suggested change
| 1. Create new quotation with storable product. | |
| 1. Create a new quotation with a storable product. |
| 1. Set quantities done in delivery picking. | ||
| 1. Validate delivery picking. | ||
|
|
||
| To see field effective date you can install *sale_order_line_menu* |
There was a problem hiding this comment.
This would fit better in INSTALL.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add field effective date in sale order line. This field is a compute with completion date of the first delivery.
@yajo @Shide @rafaelbn @Gelojr please review
MT-6075 @moduon