[17.0][MIG] sale_order_line_tag #3128
Conversation
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_tag Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_tag/es/
Currently translated at 100.0% (12 of 12 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_line_tag Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_line_tag/it/
|
Hi @ernestotejeda, |
|
@Anxo82 |
pmonje-duonex
force-pushed
the
17.0-mig-sale_order_line_tag
branch
from
60ada4f
to
52e0856
Compare
pmonje-duonex
force-pushed
the
17.0-mig-sale_order_line_tag
branch
from
6a38589
to
4ab0e30
Compare
| <menuitem | ||
| id="sale_order_line_tag_action_menu" | ||
| name="Sales Order Line Tags" | ||
| parent="sale.menu_sale_config" | ||
| action="sale_order_line_tag_action" | ||
| sequence="25" | ||
| /> |
There was a problem hiding this comment.
Suggested improvement:
| <menuitem | |
| id="sale_order_line_tag_action_menu" | |
| name="Sales Order Line Tags" | |
| parent="sale.menu_sale_config" | |
| action="sale_order_line_tag_action" | |
| sequence="25" | |
| /> | |
| <menuitem | |
| id="sale_order_line_tag_action_menu" | |
| name="Sales Order Line Tags" | |
| parent="sale.menu_sales_config" | |
| action="sale_order_line_tag_action" | |
| sequence="20" | |
| /> |
With such imp, sale line tag management is moved from general settings to custom Sales Order settings:
There was a problem hiding this comment.
Improvement changes done, could you check the improvement?
Thanks for reviewing @dalonsod !
|
@SMaciasOSI could you review? Thanks! |
|
/ocabot migration sale_order_line_tag |
| action="sale_order_line_tag_action" | ||
| sequence="25" | ||
| sequence="20" |
There was a problem hiding this comment.
@pmonje-duonex Why changing this ?
There was a problem hiding this comment.
This change was suggested by me. Once this menu was moved to "Sales Order" submenu, I've inspected existing submenus for sale and sale_management addons and sequence starts from 1 sequence for Quotation Templates and continues with Sales tags (10)... and then simply proposed 20. There's no problem keeping 25 IMO,
There was a problem hiding this comment.
First of all, I apologise for the delay in replying, I had several urgent projects on my way back from the event.
Thanks @dalonsod for answering @rousseldenis question and @rousseldenis for reviewing the proposed changes.
The change of position of the item comes from @dalonsod improvement proposal.
But the change of the sequence value was made by me because the previous menu item has the value 10, I changed the sale_order_line_tags value to 20 to keep uniformity in the sequence values. Most of the menus I have checked the sequence values increase by 10. If there is any inconvenience by changing this value I can keep the previous one.
Standard migration