Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][FIX] sale_order_line_packaging_qty #3118

Open
wants to merge 1 commit into
base: 13.0
Choose a base branch
from

Conversation

acsonefho
Copy link
Contributor

In some case, the product_packaging is empty so the product_uom_id too and the rounding is not possible.
This fix force a default value (2) for the rounding.

Copy link

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, Thanks!

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least, change the float_is_zero() argument

In some case, the product_packaging is empty so the product_uom_id too and the rounding is not possible.
This fix force a default value (2) for the rounding
@acsonefho acsonefho force-pushed the 13.0-sale_order_line_packaging_qty_fix_rounding branch from a738a2d to 9cb1fe6 Compare May 14, 2024 07:28
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants