-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][FIX] sale_order_line_packaging_qty #3118
base: 13.0
Are you sure you want to change the base?
[13.0][FIX] sale_order_line_packaging_qty #3118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least, change the float_is_zero() argument
In some case, the product_packaging is empty so the product_uom_id too and the rounding is not possible. This fix force a default value (2) for the rounding
a738a2d
to
9cb1fe6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: code review
In some case, the
product_packaging
is empty so theproduct_uom_id
too and the rounding is not possible.This fix force a default value (
2
) for therounding
.