[17.0][MIG] fastapi: Migration to 17.0 #409

nguyenminhchien · 2024-01-08T04:34:56Z

Ref: BSRD-708

Depends on:

[17.0][MIG] endpoint_route_handler: Migration to 17.0 web-api#31

nguyenminhchien · 2024-01-08T05:19:44Z

The check failed because of the issue #141747

hunghn · 2024-01-12T10:05:51Z

Thank you, Mr. Chien, for your contribution. It works for me.

lmignon

@nguyenminhchien Thank you for the migration. Con you remove the dependency on odoo-addon-endpoint-route-handler @ git+https://github.com/OCA/web-api.git@refs/pull/31/head#subdirectory=endpoint_route_handler This one is merged.

nguyenminhchien · 2024-01-24T02:19:46Z

@nguyenminhchien Thank you for the migration. Con you remove the dependency on odoo-addon-endpoint-route-handler @ git+https://github.com/OCA/web-api.git@refs/pull/31/head#subdirectory=endpoint_route_handler This one is merged.

Removed, thanks.

gurneyalex · 2024-01-25T17:22:17Z

/ocabot migration fastapi

gurneyalex · 2024-02-02T07:42:33Z

@lmignon @sbidoul it seems that Odoo 17 has issues with the addons having a 16.0.x.y.z version, even if they are installable=False

cf. https://github.com/OCA/rest-framework/actions/runs/7634588421/job/20798693591?pr=409#step:7:74

Is this something you prefer reporting as an issue to Odoo or handle in the test scripts or process with a commit updating the versions of the uninstallable addons in the repo?

lmignon · 2024-02-02T08:45:44Z

@lmignon @sbidoul it seems that Odoo 17 has issues with the addons having a 16.0.x.y.z version, even if they are installable=False

cf. https://github.com/OCA/rest-framework/actions/runs/7634588421/job/20798693591?pr=409#step:7:74

Is this something you prefer reporting as an issue to Odoo or handle in the test scripts or process with a commit updating the versions of the uninstallable addons in the repo?

An issue is open on odoo regarding this problem odoo/odoo#141747

rven · 2024-02-05T08:24:30Z

After an update of Odoo the following error is raised on the fastapi module

odoo.tools.convert.ParseError: while parsing /opt/odoo/parts/oca_pull/fastapi/security/ir_rule+acl.xml:37
2002Invalid domain: <class 'NameError'>: "name 'authenticated_partner_id' is not defined" while evaluating
2003" ['|', ('user_id', '=', user.id), ('id', '=', authenticated_partner_id)]"
To fix this, the following code needs to be changed in fastapi/models/ir_rule.py

    @api.model
    def _eval_context(self):
        ctx = super()._eval_context()
        if "authenticated_partner_id" in self.env.context:
            ctx["authenticated_partner_id"] = self.env.context[
                "authenticated_partner_id"
            ]
        return ctx

Should be changed to this

    @api.model
    def _eval_context(self):
        ctx = super()._eval_context()
        ctx["authenticated_partner_id"] = self.env.context.get("authenticated_partner_id")
        return ctx

sbidoul · 2024-02-05T09:12:43Z

@rven this looks like #410

nguyenminhchien · 2024-02-19T03:12:40Z

@rven this looks like #410

@rven @sbidoul I have picked #410

ahmed-aly-aut · 2024-02-20T16:16:47Z

@nguyenminhchien this pull request is now needed too #416

nguyenminhchien · 2024-02-21T02:58:57Z

@nguyenminhchien this pull request is now needed too #416

I picked this one.

lmignon · 2024-04-16T08:25:25Z

/ocabot merge nobump

lmignon

Code review only

OCA-git-bot · 2024-04-16T08:32:24Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-409-by-lmignon-bump-nobump, awaiting test results.

Signed-off-by lmignon

dreispt · 2024-05-03T08:12:39Z

/ocabot merge nobump

OCA-git-bot · 2024-05-03T08:12:45Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-409-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

nilshamerlinck · 2024-05-24T03:58:38Z

Hi @dreispt could you please try again your merge bot command? I believe it wasn't going through previously because of an old pending runboat build, but this has now been fixed thanks to Chien's rebase

OCA-git-bot · 2024-05-24T08:23:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

lmignon · 2024-05-24T14:18:40Z

/ocabot merge nobump

OCA-git-bot · 2024-05-24T14:19:06Z

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-409-by-lmignon-bump-nobump, awaiting test results.

Signed-off-by lmignon

nilshamerlinck · 2024-05-26T09:35:00Z

Hi @dreispt could you please try again your merge bot command? I believe it wasn't going through previously because of an old pending runboat build, but this has now been fixed thanks to Chien's rebase

Yikes, wrong hypothesis 😅

Hi @sbidoul the 17.0 branch of this repo is based on 16.0 and some manual changes

Do you think it could now be initialized "normally" through copier?

sbidoul

A couple of comments "en passant".

There are a few missing commits from the 16.0 branch. Would be nice to pick them up before merging.

I'll look at why the bot does not merge.

sbidoul · 2024-05-26T09:45:08Z

fastapi/__manifest__.py

@@ -30,5 +30,5 @@
        ]
    },
    "development_status": "Beta",
-    "installable": False,
+    # "installable": False,


Suggested change

# "installable": False,

"installable": True,

Or remove the line.

sbidoul · 2024-05-26T09:56:22Z

fastapi/schemas.py

+    limit: Optional[int] = None  # noqa: UP007
+    offset: Optional[int] = None  # noqa: UP007


Suggested change

limit: Optional[int] = None # noqa: UP007

offset: Optional[int] = None # noqa: UP007

limit: int | None

offset: int | None

Would this work?

sbidoul · 2024-05-26T10:14:53Z

Hm, weird. Trying again.

/ocabot merge nobump

OCA-git-bot · 2024-05-26T10:15:10Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-409-by-sbidoul-bump-nobump, awaiting test results.

Signed-off-by sbidoul

If you pass an override of the authenticated_partner_impl to the _create_test_client method, don't override it by a default one

This is to ensure that `retrying` in `service/model.py` does not try to flush.

This reverts commit 8be7fbb.

Currently translated at 100.0% (41 of 41 strings) Translation: rest-framework-16.0/rest-framework-16.0-fastapi Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-fastapi/it/

…en evaluating ir rules This fix is needed since a modificiation of ir.rule that checks the domain when creating/modifying ir rules The solution is to set authenticate_partner_id to False when it is not present in context

From odoo/odoo@cb1d057, the orignal werkzeug request is wrapped in a dedicated class to keep under control the attributes developers use. This change add code to make the fastapi addon working with version including this last change and prior version refs OCA#414

sbidoul · 2024-05-26T10:29:01Z

Ah I understand #409 (comment) now. The base branch CI was sill configured for 16.0. I ran copier update --trust, answered the questions for 17.0 and rebased.

nguyenminhchien marked this pull request as ready for review January 8, 2024 05:19

nguyenminhchien mentioned this pull request Jan 8, 2024

Migration to version 17.0 #395

Open

18 tasks

sudhir-erpharbor mentioned this pull request Jan 19, 2024

[17.0] Changed the version in menifest for v17 #408

Closed

lmignon reviewed Jan 23, 2024

View reviewed changes

nguyenminhchien force-pushed the 17.0-mig-fastapi branch from bca16d5 to db8104d Compare January 24, 2024 02:18

OCA-git-bot added this to the 17.0 milestone Jan 25, 2024

nguyenminhchien force-pushed the 17.0-mig-fastapi branch from db8104d to f79a73b Compare February 19, 2024 03:10

nguyenminhchien requested a review from lmignon February 19, 2024 03:12

nguyenminhchien force-pushed the 17.0-mig-fastapi branch 2 times, most recently from 114895e to 956c1a3 Compare February 21, 2024 02:56

lmignon added the 17.0 label Mar 14, 2024

lmignon approved these changes Apr 16, 2024

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Apr 16, 2024

Merge PR #409 into 17.0

da91417

Signed-off-by lmignon

OCA-git-bot added the bot is merging ⏳ label Apr 16, 2024

OCA-git-bot added a commit that referenced this pull request May 3, 2024

Merge PR #409 into 17.0

fff310a

Signed-off-by dreispt

lmignon approved these changes May 21, 2024

View reviewed changes

nguyenminhchien force-pushed the 17.0-mig-fastapi branch from 956c1a3 to c231e78 Compare May 24, 2024 03:52

OCA-git-bot added the ready to merge label May 24, 2024

OCA-git-bot added a commit that referenced this pull request May 24, 2024

Merge PR #409 into 17.0

5108dd2

Signed-off-by lmignon

sbidoul reviewed May 26, 2024

View reviewed changes

OCA-git-bot added a commit that referenced this pull request May 26, 2024

Merge PR #409 into 17.0

427e5b6

Signed-off-by sbidoul

lmignon and others added 11 commits May 26, 2024 12:25

[FIX] fastapi: In test class don't override overrides

99c2a9f

If you pass an override of the authenticated_partner_impl to the _create_test_client method, don't override it by a default one

[BOT] post-merge updates

2470113

[FIX] fastapi: close cursor after rollback

93290e8

This is to ensure that `retrying` in `service/model.py` does not try to flush.

[BOT] post-merge updates

59d0aa9

Revert "[FIX] fastapi: close cursor after rollback"

bbee3e3

This reverts commit 8be7fbb.

[BOT] post-merge updates

054a9f3

Added translation using Weblate (Italian)

60787e8

Translated using Weblate (Italian)

6fa676b

Currently translated at 100.0% (41 of 41 strings) Translation: rest-framework-16.0/rest-framework-16.0-fastapi Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-fastapi/it/

[BOT] post-merge updates

72bfe6f

sbidoul force-pushed the 17.0-mig-fastapi branch from c231e78 to 91e9647 Compare May 26, 2024 10:25

nguyenminhchien force-pushed the 17.0-mig-fastapi branch from 91e9647 to a539a1a Compare May 27, 2024 03:32

nguyenminhchien requested a review from sbidoul May 27, 2024 03:33

[MIG] fastapi: Migration to 17.0

564b24e

nguyenminhchien force-pushed the 17.0-mig-fastapi branch from a539a1a to 564b24e Compare May 27, 2024 03:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] fastapi: Migration to 17.0 #409

[17.0][MIG] fastapi: Migration to 17.0 #409

nguyenminhchien commented Jan 8, 2024 •

edited

nguyenminhchien commented Jan 8, 2024 •

edited

hunghn commented Jan 12, 2024 •

edited

lmignon left a comment

nguyenminhchien commented Jan 24, 2024

gurneyalex commented Jan 25, 2024

gurneyalex commented Feb 2, 2024

lmignon commented Feb 2, 2024

rven commented Feb 5, 2024

sbidoul commented Feb 5, 2024

nguyenminhchien commented Feb 19, 2024

ahmed-aly-aut commented Feb 20, 2024

nguyenminhchien commented Feb 21, 2024

lmignon commented Apr 16, 2024

lmignon left a comment

OCA-git-bot commented Apr 16, 2024

dreispt commented May 3, 2024

OCA-git-bot commented May 3, 2024

nilshamerlinck commented May 24, 2024

OCA-git-bot commented May 24, 2024

lmignon commented May 24, 2024

OCA-git-bot commented May 24, 2024

nilshamerlinck commented May 26, 2024

sbidoul left a comment

sbidoul May 26, 2024

sbidoul May 26, 2024

nguyenminhchien May 27, 2024

sbidoul commented May 26, 2024

OCA-git-bot commented May 26, 2024

sbidoul commented May 26, 2024

		limit: Optional[int] = None # noqa: UP007
		offset: Optional[int] = None # noqa: UP007

[17.0][MIG] fastapi: Migration to 17.0 #409

Are you sure you want to change the base?

[17.0][MIG] fastapi: Migration to 17.0 #409

Conversation

nguyenminhchien commented Jan 8, 2024 • edited

nguyenminhchien commented Jan 8, 2024 • edited

hunghn commented Jan 12, 2024 • edited

lmignon left a comment

Choose a reason for hiding this comment

nguyenminhchien commented Jan 24, 2024

gurneyalex commented Jan 25, 2024

gurneyalex commented Feb 2, 2024

lmignon commented Feb 2, 2024

rven commented Feb 5, 2024

sbidoul commented Feb 5, 2024

nguyenminhchien commented Feb 19, 2024

ahmed-aly-aut commented Feb 20, 2024

nguyenminhchien commented Feb 21, 2024

lmignon commented Apr 16, 2024

lmignon left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Apr 16, 2024

dreispt commented May 3, 2024

OCA-git-bot commented May 3, 2024

nilshamerlinck commented May 24, 2024

OCA-git-bot commented May 24, 2024

lmignon commented May 24, 2024

OCA-git-bot commented May 24, 2024

nilshamerlinck commented May 26, 2024

sbidoul left a comment

Choose a reason for hiding this comment

sbidoul May 26, 2024

Choose a reason for hiding this comment

sbidoul May 26, 2024

Choose a reason for hiding this comment

nguyenminhchien May 27, 2024

Choose a reason for hiding this comment

sbidoul commented May 26, 2024

OCA-git-bot commented May 26, 2024

sbidoul commented May 26, 2024

nguyenminhchien commented Jan 8, 2024 •

edited

nguyenminhchien commented Jan 8, 2024 •

edited

hunghn commented Jan 12, 2024 •

edited