Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] report_csv #856

Open
wants to merge 36 commits into
base: 17.0
Choose a base branch
from

Conversation

pedroguirao
Copy link

No description provided.

@pedroguirao pedroguirao mentioned this pull request Feb 22, 2024
24 tasks
@pedrobaeza pedrobaeza changed the title [17.0][MIG] report csv [17.0][MIG] report_csv Feb 22, 2024
@pedrobaeza
Copy link
Member

/ocabot migration report_csv

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 22, 2024
Copy link

@john-herholz-dt john-herholz-dt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good except the version number.

@@ -6,7 +6,7 @@
"author": "Creu Blanca, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/reporting-engine",
"category": "Reporting",
"version": "16.0.2.0.0",
"version": "17.0.2.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 17.0.1.0.0, right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! thanks!

@ridge-works-fs
Copy link

ridge-works-fs commented Apr 17, 2024

Looks good and I was able to generate a CSV report against another model not already demonstrated.

Are there other tests that I can assist with before this PR is merged?

@yostashiro
Copy link
Sponsor Member

We have this refactoring PR #864 for 16.0 which will affect this PR if accepted. Would be nice if we could get comments on the refactoring PR.

@bealdav
Copy link
Member

bealdav commented May 31, 2024

Yes @yostashiro @pedroguirao

Could you depend on this new module report_format_option please ? Thanks

#889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet