-
-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] report_csv #856
base: 17.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (14 of 14 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_csv Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_csv/it/
/ocabot migration report_csv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good except the version number.
report_csv/__manifest__.py
Outdated
@@ -6,7 +6,7 @@ | |||
"author": "Creu Blanca, Odoo Community Association (OCA)", | |||
"website": "https://github.com/OCA/reporting-engine", | |||
"category": "Reporting", | |||
"version": "16.0.2.0.0", | |||
"version": "17.0.2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 17.0.1.0.0, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! thanks!
5fb568a
to
0c7163d
Compare
Looks good and I was able to generate a CSV report against another model not already demonstrated. Are there other tests that I can assist with before this PR is merged? |
We have this refactoring PR #864 for 16.0 which will affect this PR if accepted. Would be nice if we could get comments on the refactoring PR. |
Could you depend on this new module report_format_option please ? Thanks |
No description provided.