Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] project_template: Migration to 17.0 #1245

Open
wants to merge 59 commits into
base: 17.0
Choose a base branch
from

Conversation

aisopuro
Copy link

@aisopuro aisopuro commented Mar 5, 2024

No description provided.

@aisopuro
Copy link
Author

aisopuro commented Mar 5, 2024

Includes a fix for an issue I detected in the code.

Based on codecov's reports, it seems like the only way to increase coverage is to add a bunch of dumb tests like "check we don't do anything if the project doesn't have a name". Could the maintainers give an opinion as to whether it is actually necessary to hit these coverage targets on migration PRs?

patrickrwilson and others added 28 commits March 6, 2024 13:21
Adding new Project Template Module

[FIX] PEP8 Errors

Revert "[FIX] PEP8 Errors"

This reverts commit 90f9cd9.

[FIX] Fixed PEP8 Formatting

First upload tests showed some lint issues which this commit has the fixes for.

[FIX] Fixed LINT Issue

Removed unreachable code that was not needed.

[FIX] RunBot Warning

Fixed runbot warning about @Class to hasclass

[UPD] Suggested Changes

Updated based on suggested changes on other submitted modules.

[UPD] Manifest and Readme

Updated Manifest and Readme based on comments on other module pr's.

[UPD] Suggested Changes

Updated code based on suggested code changes from reviewer.

[FIX] Creation Error

Fixed create project error when creating project via configuration/projects menu

[UPD] Menu and Bool Change

Removed Template Menu (Filter option still there) and moved Bool up below name. (From reviewer suggestions)

[UPD] Kanban Menu

Removed button, added link to kanban menu. Start of tests

[UPD] Remove project_milestone code

Removed the project_milestone code and will create a separate module for that purpose.
Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/
There is an error if the template name gets modified so needed to add a new else statement for the new_name.
Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/pt/
Currently translated at 85.7% (6 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/fr/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/sl/
Currently translated at 14.3% (1 of 7 strings)

Translation: project-12.0/project-12.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_template/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-13.0/project-13.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_template/he/
Yvesldff and others added 26 commits March 6, 2024 13:21
Currently translated at 100.0% (7 of 7 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr/
Currently translated at 70.0% (7 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/fr_FR/
Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/de/
Currently translated at 100.0% (10 of 10 strings)

Translation: project-14.0/project-14.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_template/sv/
Since in  original odoo `15.0` version project subtasks
has been deleted so changes also done in this module.
We don't need project subtasks anymore because odoo don't have it.
Currently translated at 100.0% (10 of 10 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/de/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/hr/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/it/
Currently translated at 100.0% (7 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/pt_BR/
Currently translated at 85.7% (6 of 7 strings)

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/nl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-16.0/project-16.0-project_template
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_template/
Previously, if multiple tasks in a template project had the same name,
their end_date-values were not copied properly.
@aisopuro
Copy link
Author

aisopuro commented Mar 6, 2024

Rebased on 17.0 and re-ran pre-commit.

@aisopuro aisopuro mentioned this pull request Apr 25, 2024
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet