[IMP] project_type module #1235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone tell me what is the problem ? |
added 2 commits
February 9, 2024 12:47
CRogos
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Here are the OCA Guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst
Have a look at the pre-commit installation.
https://github.com/OCA/maintainer-tools/wiki/Install-pre-commit
pre-commit should format your code before committing it.
And you need to squash all your commits.
| @@ -21,6 +22,7 @@ class ProjectType(models.Model): | |||
| project_ok = fields.Boolean(string="Can be applied for projects", default=True) | |||
| task_ok = fields.Boolean(string="Can be applied for tasks") | |||
| code = fields.Char(copy=False) | |||
| sequence = fields.Integer(string="Order") | |||
There was a problem hiding this comment.
You should not change the display name. Order is not optimal because of Sales Order / Purchase Order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an integer sequence field and handle order management in tree view.