Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] project_task_code #1218

Open
wants to merge 60 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] project_task_code #1218

wants to merge 60 commits into from

Conversation

ygol
Copy link
Contributor

@ygol ygol commented Jan 18, 2024

Standard migration to 17.0

oihane and others added 30 commits January 18, 2024 09:29
@oihane @ygol
[MOD] changing from odoomrp to avanzosc
7067390
@oihane @ygol
[FIX] Code error when copying a task
e8a2037
@oihane @ygol
[IMP] <project_task_code> adapted to OCA
bda1ff1
@oihane @ygol
[IMP] <project_task_code> Added docstring to pre and post init-hooks
44433ed
@sbidoul @ygol
[UPD] prefix versions with 8.0
f107803
@pedrobaeza @ygol
[MIG] Make modules uninstallable
3c0f1e2
@pedrobaeza @ygol
[MIG] Rename manifest files
08ea7d7
@cubells @ygol
project_task_code module
7b1d8e7
@ygol
[MIG] project_task_code: Migrate to 10.0
1b24e57 
OCA Transbot updated translations from Transifex

[MIG] project_task_code: Migrate to 10.0

Edit init and XML

Add env

Change task_ids to tasks

Change to @api.multi before def copy
@ygol
Requested README changes
c3375d5
@ygol
Requested XML change
b367e41
@oca-transbot @ygol
OCA Transbot updated translations from Transifex
1c7b127
@rodrigets @ygol
[MIG] project_task_code: Migration to 11.0
660d775
@rodrigets @ygol
[IMP] Implements name_get() in 'project.task'
3d3b3c1 
Relational fields and the task notification email inform the task code
@sbidoul @ygol
remove obsolete .pot files [ci skip]
0930156
@oca-travis @ygol
[UPD] Update project_task_code.pot
dc10d51
@bouvyd @ygol
[MIG] project_task_code: Migration to 12.0
e639e1c 
- adapted view (label needs a `for` attribute, use span for same result)
- use the `model_create_multi` decorator on the create override for
future-proofiness
@alexey-pelykh @ygol
[MIG] project_task_code: Migration to 12.0 (fix)
0968bb1
@oca-travis @ygol
[UPD] Update project_task_code.pot
2d38381
@oca-transbot @ygol
Update translation files
be395d3 
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@alexey-pelykh @ygol
[FIX] project_task_code: invalid variable
9fdf375
@mvrodriguez @ygol
Translated using Weblate (Galician)
d34a1fb 
Currently translated at 100.0% (3 of 3 strings)

Translation: project-12.0/project-12.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_code/gl/
@OCA-git-bot @ygol
[ADD] icon.png
1f2f0e8
@tbaden @ygol
[FIX][12.0] project_task_code missing api.multi
7a5add0
@OCA-git-bot @ygol
[UPD] README.rst
d3d653d
@Saran440 @ygol
[13.0][MIG] project_task_code
9e37f78
@oca-travis @ygol
[UPD] Update project_task_code.pot
d61571a
@oca-transbot @ygol
Update translation files
e042fac 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-13.0/project-13.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_task_code/
@OCA-git-bot @ygol
pre-commit update
c307dc9
@alexey-pelykh @ygol
[UPD] Brainbean Apps => CorporateHub
002f81c
Yvesldff and others added 22 commits January 18, 2024 09:29
@Yvesldff @ygol
Translated using Weblate (French (France))
e0e8b85 
Currently translated at 50.0% (3 of 6 strings)

Translation: project-14.0/project-14.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/fr_FR/
@alan196 @ygol
Translated using Weblate (Spanish (Mexico))
2074d11 
Currently translated at 100.0% (3 of 3 strings)

Translation: project-14.0/project-14.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/es_MX/
@simonstromb @ygol
Translated using Weblate (Swedish)
ce3bc54 
Currently translated at 100.0% (3 of 3 strings)

Translation: project-14.0/project-14.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_task_code/sv/
@bizzappdev @ygol
[MIG] project_task_code : Migrate project_task_code.
131c24e
@ygol
[UPD] Update project_task_code.pot
8f38f36
@OCA-git-bot @ygol
[UPD] README.rst
b385f4e
@Noel000 @ygol
Translated using Weblate (Catalan)
f7d0c53 
Currently translated at 100.0% (3 of 3 strings)

Translation: project-15.0/project-15.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_task_code/ca/
@gurneyalex @ygol
[FIX] project_task_code: in place argument modification
d328db2 
The overload of project.task::create  in the project_task_code would
mutate the dictionaries passed in the vals_list argument. This is a bad
practice which can have unintended side effects in caller code.

We fix this by creating a new dictionary containing the additional field
value and passing this dictionary in the call to super().create()
@OCA-git-bot @ygol
project_task_code 15.0.1.0.2
0cc6aa9
@yankinmax @ygol
[15.0][FIX] project_task_code: Fix null value in column code, that vi…
77f41ad 
…olates not-null constraint
@OCA-git-bot @ygol
project_task_code 15.0.1.0.3
2e0bdfd
@OCA-git-bot @ygol
[IMP] update dotfiles [ci skip]
8508e70
@rolandojduartem @ygol
[FIX] project_task_code: Make sequence avalaible for all companies
80c22b0 
Currently, the sequence that generates task codes is only available for the
main company [1], which could cause issues at the moment of the installation
process with another modules in multi-companies cases, for example
project_timesheet_holiday [2] because in the other companies, this line [3]
will return False or "/" and will trigger the UNIQUE constraint. With
this change, the sequence can be used by any company [4] using the False
value in the field company_id.

References:
[1] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L148
[2] https://github.com/odoo/odoo/blob/7b6c25e/addons/project_timesheet_holidays/models/res_company.py#L14
[3] https://github.com/OCA/project/blob/9d08f2d/project_task_code/models/project_task.py#L29
[4] https://github.com/odoo/odoo/blob/7b6c25e/odoo/addons/base/models/ir_sequence.py#L282
@OCA-git-bot @ygol
project_task_code 15.0.1.0.4
6188839
@kg-ucs @ygol
[MIG] project_task_code: Migration to 16.0
baf8d9b
@robinkeunen @ygol
[FIX] project_task_code: unique code in company
e050b1f
@ygol
[UPD] Update project_task_code.pot
8679a42
@OCA-git-bot @ygol
[BOT] post-merge updates
743b6a3
@weblate @ygol
Update translation files
265501d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/
@mymage @ygol
Translated using Weblate (Italian)
997da46 
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
@Ivorra78 @ygol
Translated using Weblate (Spanish)
bfb78f4 
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es/
@ibuioli @ygol
Translated using Weblate (Spanish (Argentina))
e06c4e5 
Currently translated at 100.0% (4 of 4 strings)

Translation: project-16.0/project-16.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/es_AR/
@ygol ygol mentioned this pull request Jan 18, 2024
Open
25 tasks
@ygol ygol force-pushed the 17.0-mig-project_task_code branch 2 times, most recently from 83e4663 to 87c2e18 Compare January 18, 2024 08:33
@nedaszilinskas
Copy link

@ygol Kanban view does not show the task code.

May I suggest the change:

<record model="ir.ui.view" id="project_task_code_kanban_view">
    <field name="name">project.task.kanban</field>
    <field name="model">project.task</field>
    <field name="inherit_id" ref="project.view_task_kanban"/>
    <field name="arch" type="xml">

        <xpath expr="//s/field[@name='name']" position="before">
            <field name="code"/><span>&amp;nbsp;</span>
        </xpath>
        <xpath expr="//t/field[@name='name']" position="before">
            <field name="code"/><span>&amp;nbsp;</span>
        </xpath>

    </field>
</record>

@ygol ygol force-pushed the 17.0-mig-project_task_code branch 2 times, most recently from 35410f2 to 6dc7191 Compare May 18, 2024 07:02
@ygol ygol force-pushed the 17.0-mig-project_task_code branch from 6dc7191 to c47b395 Compare May 18, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet