Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] pos_product_label: improve print_product_labels #1181

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] pos_product_label: improve print_product_labels #1181

wants to merge 1 commit into from
+25 −13

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Apr 24, 2024 •
edited

This change

  • Decouple print_product_labels for better inheritance. Notably, print label with extra information such as packaging. Hence, _prepare_product_label_layout_data is used to add more data.

Note

  • The failed test is not related to this change

@OCA-git-bot
Copy link
Contributor

Hi @ivantodorovich,
some modules you are maintaining are being modified, check this out!

ivantodorovich
ivantodorovich approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ivantodorovich
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1181-by-ivantodorovich-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 25, 2024
@OCA-git-bot
Merge PR #1181 into 16.0
41f4368 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1181-by-ivantodorovich-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@ivantodorovich ivantodorovich added this to the 16.0 milestone Apr 25, 2024
@ivantodorovich
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 16.0.

@dreispt
Copy link
Sponsor Member

dreispt commented May 18, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-1181-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 18, 2024
@OCA-git-bot
Merge PR #1181 into 16.0
b2bf3ff 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1181-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@trisdoan trisdoan force-pushed the 16.0-imp-pos_product_label branch from f3bb52a to 3cfdf11 Compare May 19, 2024 02:39
@trisdoan
Copy link
Contributor Author

Hello @dreispt, please help to remerge 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@santostelmo santostelmo santostelmo approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@trisdoan @OCA-git-bot @ivantodorovich @dreispt @santostelmo