Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] pos_membership_extension : change membership category #1180

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from
Open

[16.0] pos_membership_extension : change membership category #1180

wants to merge 3 commits into from

Conversation

legalsylvain
Copy link
Contributor

Use case :

  • select a customer that belong to a membership category
  • select then MANY products that are reserved to this membership category
  • switch then to a "normal" customer that doesn't belong to the membership category

Before :

  • Not all lines are removed
  • the customer is not changed.

After

  • the customer is correctly changed
  • all the lines are correctly removed.

Ref : https://stackoverflow.com/a/9882349

@legalsylvain
[FIX] pos_membership_extension : always change the customer, even if …
82339f7 
…some products have been removed, due to membership constraints
@legalsylvain
[FIX] pos_membership_extension : correctly remove all the incorrect s…
b2b0b30 
…elected lines, preventing skipping order lines, if many lines have to be removed
@legalsylvain
[REF] pos_membership_extension : use correct syntax to overload PoS J…
aa2015f 
…S model. So remove eslint disabling
@legalsylvain legalsylvain added this to the 16.0 milestone Apr 22, 2024
ivantodorovich
ivantodorovich approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@legalsylvain @ivantodorovich