Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] mig pos_product_mergeable_line #1145

Open
wants to merge 11 commits into
base: 16.0
Choose a base branch
from

Conversation

legalsylvain
Copy link
Contributor

Quite trivial migration of module pos_product_mergeable_line from 12.0 to 16.0

Description

This module extends the Odoo Point of Sale to prevent to merge lines if product
is configured.

By default, new line can be merged with a previous one if the informations are the same. (same product, same restaurant note, etc...) and if the UoM Category allow it.

The new module add a boolean field 'Mergeable Line' (default True).

If unchecked, the product will never be merged into another line.

That's important in some context, as in the management of returnable products, where we want to have a record of all movements.

Configure

  • Go to "Point of Sale > Product" and edit a product

  • Uncheck the checkbox "Mergeable line"

product_form

@legalsylvain
Copy link
Contributor Author

/ocabot migration pos_product_mergeable_line

@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_product_mergeable_line branch from dbd1320 to 22a7c3c Compare January 26, 2024 23:50
@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 26, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 26, 2024
30 tasks
Copy link

@quentinDupont quentinDupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise functional review ✔️

const PosProductMergeableLineOrderline = (OriginalOrderline) =>
class extends OriginalOrderline {
can_be_merged_with(orderline) {
console.log("==================");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove console log :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed ! Thanks !
Note : I thought that console.logs were forbidden and that the CI would be red, but that's not the case.

@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_product_mergeable_line branch from 22a7c3c to 5da12f0 Compare January 31, 2024 13:54
@quentinDupont quentinDupont self-requested a review February 1, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants