-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][l10n_br_sale] enable inline tree view edition - POC #2992
Draft
rvalyi
wants to merge
6
commits into
OCA:14.0
Choose a base branch
from
akretion:14.0-sale-line-edition2
base: 14.0
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvalyi
force-pushed
the
14.0-sale-line-edition2
branch
from
March 29, 2024 05:58
d120157
to
7fbcadc
Compare
rvalyi
force-pushed
the
14.0-sale-line-edition2
branch
2 times, most recently
from
March 29, 2024 06:32
067c309
to
3e24eca
Compare
Hi @renatonlima, |
was removed with 'replace' by @renatonlima in OCA@20ba74e#diff-12651ac41fcb8582c5a21564a51ae93028e248c666a5147a3fd364ea4f68534eR51 probably by mistake... (and then refactored by @mbcosta with a dynamic 'invisible' attribute)
so XML matches the visual order of elements
to match the visual order of elements
rvalyi
force-pushed
the
14.0-sale-line-edition2
branch
from
March 30, 2024 02:32
3e24eca
to
f913f3b
Compare
rvalyi
force-pushed
the
14.0-sale-line-edition2
branch
from
March 30, 2024 03:16
f913f3b
to
cde6c9c
Compare
Note to self: I screw it with the recent commit split. TODO compare with my local 14.0-sale-line-edition2-bk backup branch... |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS (não fazer merge 1h depois hein pfv)
With this PR by default user edit sale orders using the native "editable" inline tree view. But a new group is created. If the user belong to this new group, then he will use the detailed popup "form" view with all details.
The goal is to:
For more explanations you can read: https://odoo-community.org/groups/contributors-15/contributors-1809168?mode=thread&date_begin=&date_end=
The diff is not as crazy as it might look as most of the diff is just moving pieces around to match the top to bottom visual order. I also added a few comments.
[EDIT]: I split the commits so you can follow the commits to see how I first moved chunks of XML around.
Replaces #2952
This new PR is future proof, considering this https://odoo-community.org/groups/contributors-15/contributors-1809168?mode=thread&date_begin=&date_end=