Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][l10n_br_sale] enable inline tree view edition - POC #2992

Draft
wants to merge 6 commits into
base: 14.0
Choose a base branch
from

Conversation

rvalyi
Copy link
Member

@rvalyi rvalyi commented Mar 29, 2024

WORK IN PROGRESS (não fazer merge 1h depois hein pfv)

With this PR by default user edit sale orders using the native "editable" inline tree view. But a new group is created. If the user belong to this new group, then he will use the detailed popup "form" view with all details.

The goal is to:

  • increase the compatibility with other modules (as they will expect the default tree view)
  • enable faster edition for some users who don't need fiscal details (specially for companies from the Simple fiscal regime)
  • increase the multi-localizations compatibility
  • it also makes tests run faster

For more explanations you can read: https://odoo-community.org/groups/contributors-15/contributors-1809168?mode=thread&date_begin=&date_end=

The diff is not as crazy as it might look as most of the diff is just moving pieces around to match the top to bottom visual order. I also added a few comments.
[EDIT]: I split the commits so you can follow the commits to see how I first moved chunks of XML around.

Replaces #2952
This new PR is future proof, considering this https://odoo-community.org/groups/contributors-15/contributors-1809168?mode=thread&date_begin=&date_end=

@rvalyi rvalyi marked this pull request as draft March 29, 2024 05:59
@rvalyi rvalyi force-pushed the 14.0-sale-line-edition2 branch 2 times, most recently from 067c309 to 3e24eca Compare March 29, 2024 06:32
@OCA-git-bot
Copy link
Contributor

Hi @renatonlima,
some modules you are maintaining are being modified, check this out!

was removed with 'replace' by @renatonlima in
OCA@20ba74e#diff-12651ac41fcb8582c5a21564a51ae93028e248c666a5147a3fd364ea4f68534eR51
probably by mistake... (and then refactored by @mbcosta with a dynamic
'invisible' attribute)
so XML matches the visual order of elements
to match the visual order of elements
@rvalyi
Copy link
Member Author

rvalyi commented Mar 30, 2024

Note to self: I screw it with the recent commit split. TODO compare with my local 14.0-sale-line-edition2-bk backup branch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants