[17.0]]MIG]sale_stock_analytic: Migration to 17.0 #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Stock analytic XML part is now migrated Add logo for generic modules
- migration point, put all the modules to not installable
This module allows the user to generate analytic information from stock moves. - Fixed flake8 and pylint errors.
Remove sale and purchase dependency. Add test Only assign analytic account if account != valuation acc Changing field name account_analytic_id Adjust to OCA latest guidelines. Add some usahe info on README
Remove remaining encoding hints. Correct lint in test Correct flake8 in test Fix documentation and test_flake8
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-11.0/account-analytic-11.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-11-0/account-analytic-11-0-stock_analytic/de/
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/ca/
Currently translated at 100.0% (3 of 3 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/hr/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/de/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/pt/
Currently translated at 100.0% (4 of 4 strings) Translation: account-analytic-12.0/account-analytic-12.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-12-0/account-analytic-12-0-stock_analytic/es/
(cherry picked from commit 9255622)
Currently translated at 100.0% (5 of 5 strings) Translation: account-analytic-13.0/account-analytic-13.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-13-0/account-analytic-13-0-stock_analytic/pt_BR/
Currently translated at 100.0% (6 of 6 strings) Translation: account-analytic-14.0/account-analytic-14.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-stock_analytic/pt_BR/
Currently translated at 100.0% (6 of 6 strings) Translation: account-analytic-14.0/account-analytic-14.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-14-0/account-analytic-14-0-stock_analytic/ca/
If we add extra move lines in stock pickings and wanted to set the analytic account on it, as the related move is not yet created, the behaviour of the related field is not wanted. So, store the analytic account on move line level too and add it in the values preparation hooks.
- Add validation on analytic distribution according to how it is done in other models (account.move.line, sale.order.line, etc.). - Update readme to reflect the current design. - Other cosmetic adjustments.
…ceipt picking view
Currently translated at 88.8% (8 of 9 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_analytic/nl/
Currently translated at 100.0% (9 of 9 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_analytic/es/
Currently translated at 100.0% (9 of 9 strings) Translation: account-analytic-16.0/account-analytic-16.0-stock_analytic Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-stock_analytic/pt_BR/
cvinh
suggested changes
Feb 9, 2024
| sol = sol_model.browse(sol_id) | ||
| analytic_distribution = sol.analytic_distribution | ||
| if analytic_distribution: | ||
| move_values.update({"analytic_distribution": analytic_distribution}) |
There was a problem hiding this comment.
You might take into account the case where analytic account is at the sale order level...
you might cherry-pick DynAppsNV#2
There was a problem hiding this comment.
Alternatively, Odoo's own logic merges the two when preparing the invoice line information from a sale line: https://github.com/odoo/odoo/blob/1648ee1abff1ae12b3933baa85a2e048fa2eb557/addons/sale/models/sale_order_line.py#L1142C9-L1142C35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: