Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to requestWithAutomaticAccessTokenRenewal #693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vgritsenko
Copy link
Contributor

This fixes error handling, and makes a couple of improvements to implementation of the requestWithAutomaticAccessTokenRenewal function:

  • Pass all error responses as-is, and look only for the tokenExpired;
  • Treat onTokenRenewal parameter as truly optional - perform the token renewal even if onTokenRenewal is nil;
  • Do not keep a strong reference to self in the completion block for renewAccessToken call.

The main issue I had was that requestWithAutomaticAccessTokenRenewal would swallow all errors and convert them to the empty tokenExpired errors, preventing any possibility of implementing custom error handling logic on the client side:

completion(.failure(.tokenExpired(error: nil)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant