Make TimeoutInterval configurable to fix issue OAuthSwift/issues/667 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…initialiser up to the top level OAuth1/2Swift functions to allow them to be overriden.
20 tasks
|
@phimage any thoughts on this PR? |
|
Any update on this as yet? |
|
A thought from a peanut gallery... This seems to add an extra parameter into a lot of methods. Wouldn't it be better to subclass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than providing a default timeout in the Config initialiser which is never overriden I've moved this up to the top level requests. This should mean its a non-breaking change but allows a timeoutInterval to be passed where needed and used by the UrlRequest.
This is my first open source contribution so I welcome any feedback - thanks!