Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘·πŸ»β€β™€οΈ Run Danger on GitHub Action #660

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

phatblat
Copy link
Collaborator

The Travis build is always blowing up with a "Bad credentials" error.

GET https://api.github.com/repos/OAuthSwift/OAuthSwift/pulls/659: 401 - Bad credentials // See: https://docs.github.com/rest (Octokit::Unauthorized)

Not sure how well this is going to work in a GitHub Action workflow, but with the automatic availability of the GITHUB_TOKEN for an action, it sure seems simpler to manage.

@phatblat
Copy link
Collaborator Author

The success from the new Danger check is misleading as there was an error running swiftlint.

From https://github.com/OAuthSwift/OAuthSwift

  • [new branch] ci/action/danger -> origin/ci/action/danger
    /home/runner/work/OAuthSwift/OAuthSwift/vendor/bundle/ruby/2.6.0/gems/danger-swiftlint-0.26.0/ext/swiftlint/bin/swiftlint: 1: Syntax error: "(" unexpected

I didn't realize this was also going to run swiftlint, so will need to switch to a macOS runner.

@Nef10
Copy link
Contributor

Nef10 commented May 20, 2021

Does danger still need to run SwiftLint, given that it already runs in its own action?

@phimage
Copy link
Member

phimage commented May 20, 2021

I have never configured it, but I see danger SwiftLint, I have already launch SwiftLint on linux , I see some docker and GitHub action about it

@phatblat phatblat mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants