Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example showing setting default response #17

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

darrelmiller
Copy link
Member

No description provided.

@jlk
Copy link

jlk commented Jun 27, 2022

Your commits didn't get signed this time for some reason, but yeah this would be super handy!

@darrelmiller
Copy link
Member Author

@jlk I don't usually sign my commits. The license in the repo is authoritative when it comes to IPR.

@lornajane Do you think this would be a useful addition to Overlays?

@lornajane
Copy link
Contributor

Without a pull request description, this took me a while to understand. What we're saying is that we should add these fields, conditional on them not being there already? So don't update, just add if you can. I can see some use cases, but I'm not sure "default" is the right naming for this behaviour.

In an attempt to be constructive with naming, how about add, with wording that makes it clear it will fail if the thing is there already? Or fallback - something to put in if a gap is found?

@lornajane
Copy link
Contributor

See also #32 where we have commandeered the add syntax to mean something else. I'm still not sure what this operation should be called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants