Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify constraints on Parameter Object fields (3.0.4) #3760

Merged
merged 1 commit into from May 9, 2024

Conversation

handrews
Copy link
Contributor

Fixes #1542

I'm actually uncertain if example and examples (or, for that matter, allowReserved) are really only allowed with schema, but that seems to be what's implied by the existing text? I'm happy to rearrange this if it's not quite right.

As usual, I will forward-port if accepted.


Commit Message:

This makes the relational requirements of content vs schema and associated fields more clear. The mutual exclusivity requirement is moved up to the top of the Fixed Fields section, and each table table is given a subsection clarifying its meaning. This makes it easier to follow the multi-table format, which is unusual within the OAS.

The commentary on example and examples is moved to the section on schema and related parameters as it appears to only apply in that case.

@handrews handrews added clarification requests to clarify, but not change, part of the spec param serialization Issues related to parameter and/or header serialization labels Apr 26, 2024
@handrews handrews added this to the v3.0.4 milestone Apr 26, 2024
@handrews handrews requested a review from a team April 26, 2024 20:06
This makes the relational requirements of `content` vs `schema`
and associated fields more clear.  The mutual exclusivity requirement
is moved up to the top of the Fixed Fields section, and each table
table is given a subsection clarifying its meaning.  This makes it
easier to follow the multi-table format, which is unusual within the OAS.

The commentary on `example` and `examples` is moved to the section
on `schema` and related parameters as it appears to only apply
in that case.
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I was not involved in the 3.0 spec development but I think these changes present the two alternatives for parameter description in a clearer way.

@miqui miqui merged commit eb95f04 into OAI:v3.0.4-dev May 9, 2024
1 check passed
@handrews handrews deleted the param-fields branch May 9, 2024 19:30
ralfhandl added a commit that referenced this pull request May 14, 2024
Clarify constraints on Param Obj fields (3.1.1 port of #3760)
ralfhandl added a commit that referenced this pull request May 14, 2024
Clarify constraints on Param Obj fields (3.2.0 port of #3760)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification requests to clarify, but not change, part of the spec param serialization Issues related to parameter and/or header serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants