Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix style=form examples (3.0.4) #3742

Merged
merged 2 commits into from May 3, 2024
Merged

fix style=form examples (3.0.4) #3742

merged 2 commits into from May 3, 2024

Conversation

karenetheridge
Copy link
Contributor

These should have the parameter name in the resulting string (see issue #3737).

@karenetheridge
fix style=form examples
11ba729 
These should have the parameter name in the resulting string (see issue OAI#3737).
@karenetheridge karenetheridge changed the title fix style=form examples fix style=form examples (3.0.4) Apr 25, 2024
@karenetheridge
Copy link
Contributor Author

This will need me to resolve conflicts resolved after merging #3744.

@handrews handrews added the examples requests for more or better examples in the specification label Apr 25, 2024
@handrews handrews added this to the v3.0.4 milestone Apr 25, 2024
ralfhandl
ralfhandl previously approved these changes Apr 26, 2024
View reviewed changes
handrews
handrews previously approved these changes May 1, 2024
View reviewed changes
@handrews handrews mentioned this pull request May 2, 2024
Closed
mikekistler
mikekistler reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other fixes needed here?

versions/3.0.4.md Outdated Show resolved Hide resolved
mikekistler
mikekistler approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl
Copy link
Contributor

@karenetheridge please resolve conflict

@handrews handrews dismissed stale reviews from ralfhandl and themself via 528c3c7 May 3, 2024 18:57
@handrews
Copy link
Contributor

handrews commented May 3, 2024

@ralfhandl @mikekistler @miqui @karenetheridge I resolved the conflicts but that invalidated the approval - can someone re-approve and merge?

@handrews
Copy link
Contributor

handrews commented May 3, 2024

Oh weird, it let me approve it? We might want to look into the permissions here, but for now I will merge since there were already 2 TSC approvals and the 3.1.1 and 3.2.0 versions were merged.

@handrews handrews merged commit 06a36ba into OAI:v3.0.4-dev May 3, 2024
1 check passed
@ralfhandl
Copy link
Contributor

@handrews you are not the PR author, so you can approve.
We technically require only one approval for merging, and you are a maintainer, so you can approve and then directly merge as long as no other maintainer has requested changes.

"Two TSC approvals" is currently only a convention, not technically enforced.

@karenetheridge karenetheridge deleted the v3.0.4-dev branch May 7, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfhandl ralfhandl ralfhandl left review comments

@handrews handrews handrews approved these changes

@mikekistler mikekistler mikekistler approved these changes

Assignees
No one assigned
Labels
examples requests for more or better examples in the specification
Projects
None yet
Milestone
v3.0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karenetheridge @ralfhandl @handrews @mikekistler