Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24826: Add an API endpoint to get plugin license info #5657

Conversation

fanf
Copy link
Member

@fanf fanf commented May 12, 2024

https://issues.rudder.io/issues/24826

Add a public API to get information about the installed plugins and their limits.
The returned JSON structure start by global limits if any, which are computed to present the most restrictive limits (ie, if a plugin limits to 200 nodes and one to 500, then 200 is given).

Then, we have an array with installed plugins and their specific limits if any.

Most of the PR is documentation for that API, and for the plugins repo setting API, which was missing.

There is nothing complicated at all, but two noticable points:

  • I've started using java.time API, and added the relevant formatter/etc in DateTimeFormaterService ;
  • plugin's license object needed to be migrated from rudder-web to rudder-rest;

@fanf fanf requested a review from VinceMacBuche May 12, 2024 16:49
@VinceMacBuche
Copy link
Member

There is a wip commit ! can you rebase into one ?

Copy link
Member

@VinceMacBuche VinceMacBuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart the wip commit, this is good to me and can be self merged

@fanf fanf force-pushed the enh_24826/add_an_api_endpoint_to_get_plugin_license_info branch from 03f8882 to 84a5ee0 Compare May 17, 2024 14:25
@fanf
Copy link
Member Author

fanf commented May 17, 2024

OK, merging this PR

@fanf fanf merged commit 84a5ee0 into Normation:branches/rudder/7.3 May 17, 2024
8 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants