Fixes #24769: Refactoring Elm code related to datatables #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
RaphaelGauthier
force-pushed
the
enh_24769/refactoring_elm_code_related_to_datatables
branch
from
783ee3d
to
39ad028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24769
There is now a new 'UI' folder that will contain all the modules linked to UI components (datatables, trees, notifications, etc.).
I've created an initial Datatable.elm module that groups together all the factorisable code for managing datables, and all this duplicated code has been removed from the applications. Now you just need to import this module to be able to use its functions