Fixes #24627: We can add the same score details column many times in nodes tables #5645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
reviewed
May 3, 2024
| success: function (data) { | ||
| scoreList = data.data | ||
| }, | ||
| }).done( function() {refresh(gridId)} ) |
There was a problem hiding this comment.
This does a 2nd API request for node details every time we create the table, is there a way without the refresh ?
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_24627/we_can_add_the_same_score_details_column_many_times_in_nodes_tables
branch
from
669f68b
to
28956d9
Compare
clarktsiory
reviewed
May 7, 2024
|
|
||
| $.ajax({ | ||
| type: 'GET', | ||
| url: "/rudder/secure/api/scores/list", | ||
| success: function (data) { | ||
| scoreList = data.data | ||
| }, | ||
| }) | ||
|
|
There was a problem hiding this comment.
We still have a race condition with this block, that executes asynchronously ($.ajax is fire-and-forget).
When it finished BEFORE the execution of the code that looks into localStorage for score columns, it works normally. But it often finishes AFTER, and the list is [], so we are still displaying system-updates Score instead of System updates Score (because there is a "guard" to just display the id when we don't know the name of the score...)
VinceMacBuche
force-pushed
the
bug_24627/we_can_add_the_same_score_details_column_many_times_in_nodes_tables
branch
from
28956d9
to
5a81422
Compare
|
Commit modified |
|
PR rebased |
VinceMacBuche
force-pushed
the
bug_24627/we_can_add_the_same_score_details_column_many_times_in_nodes_tables
branch
from
5a81422
to
35f8915
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
bug_24627/we_can_add_the_same_score_details_column_many_times_in_nodes_tables
branch
from
35f8915
to
483798a
Compare
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 7925b78
into
Normation:branches/rudder/8.1
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24627