Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attack motion check and jesus fix #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AimbotPvP
Copy link

Added a attack motion check that detects a lot of kill auras and fixed a bypass with jesus by moving up (or down) < 0.03 blocks

@Janmm14
Copy link

Janmm14 commented Sep 17, 2018

Lets flag all lagging players for attack motion

@0-x-2-2
Copy link

0-x-2-2 commented Sep 17, 2018

I believe AAC has a similar check so 🤔

@Janmm14
Copy link

Janmm14 commented Sep 17, 2018

The attack motion stuff is just doctoring around at symptoms. Idk what checks AAC has.

@AimbotPvP
Copy link
Author

Lets flag all lagging players for attack motion

I'm only attempting to contribute to NCP. I don't see why you're trying to be rude but if you believe this will flag all lagging players then if you want to feel free to help. I don't personally see how a person that is lagging will change the packet order of CPlayer packets.

I believe AAC has a similar check so 🤔

Negative, it'd detect LiquidBounce if that was the case

@Janmm14
Copy link

Janmm14 commented Sep 17, 2018

@AimbotPvP
Because you don't know when a tick ends for the client.
The arrival time of a packet is not enough.
It might work for low latency connections, but once players have laggy connections, multiple packets can arrive as a batch, causing them to all get processed in the same tick.
Sure it might not happen as often for legit players as for cheaters, but I'm sure current clients can easily change their behaviour.

@AimbotPvP
Copy link
Author

@AimbotPvP
Because you don't know when a tick ends for the client.
The arrival time of a packet is not enough.
It might work for low latency connections, but once players have laggy connections, multiple packets can arrive as a batch, causing them to all get processed in the same tick.
Sure it might not happen as often for legit players as for cheaters, but I'm sure current clients can easily change their behaviour.

I don't see why it wouldn't work for "laggy" connections. multiple packets CAN. I mean yeah sure, but there's a threshold and you're able to customize the time between the attacks. Sure, clients can change their behavior but that would cause them to flag FIGHT_DIRECTION as they attack the same tick as their rotations are set server-side

@0-x-2-2
Copy link

0-x-2-2 commented Sep 18, 2018

aac removed heuristics but this was definitely a heuristic in a old version of aac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants