Project maven cleanup

[sgdc3]

TODO:

• Update docs

I also added NCP to my CI setup, i added admin rights over the folder to any member of the NCP github org (authentication works via github oauth, remember allow access to the org on first login).

Jenkins build: https://ci.codemc.org/job/NoCheatPlus/job/NoCheatPlus/
Maven repository: https://repo.codemc.org/repository/maven-public/

[asofold]

What are the changes for NMS compat modules aiming for?

Did you have trouble building?

[sgdc3]

It was not following the maven standards, i also provided a repository containing NMS, so it will be possible to build it without having to run buildtools first.

[asofold]

I currently have no space for reviewing which parts are really "necessary"...

Specifically:

• A public spigot binary repository is out of the question, i'd prefer an option to build spigot right on the spot an then use it rather than that.
• Standards/conform... there seem to be many changes (e.g. spaces vs tabs), I'd prefer an overview for why which part isn't conform, perhaps an issue would've been better to start discussion.
• Not so keen to change anything concerning maven unless it doesn't build.
• (1.13 Material changes have more impact, so i'll have to focus on that.)

[sgdc3]

1. Why? you don't have any risk using it.
2. Space/Tabs:
   https://maven.apache.org/developers/conventions/code.html
3. That's not a very good idea, if something can be improved why not?

[asofold]

"Improve something" means i have to look through every line - especially if it's not at all crucial, it's probably no option at this very moment :).

There is too many type of changes mixed in the commits and this PR. With MC 1.13 in the queue there is no way to look further into it.

Best would be to separate:

• Spaces vs tabs. For a larger changeset this should be one commit for all, so an idiot can see the difference easily.
• ncpcompatnonfree as parent (good! but: did you check that certain profiles still build at all? mostly concerns latest/minimal)
• NCPCompatAggregated - due to standards, or just a fancy idea? Altering profiles and Project structure is not the type of things i do within a "spaces vs tabs commit" :p.
• (Binary repository <- not / extra pr / different topic).

This'll have to wait until i'm through with most of 1.13.

[sgdc3]

Ok, i'll wait the 1.13 release first and then start splitting my changes into more PRs ;)

[asofold]

Thank you :).

[phoenixd21]

who wants to get taht crpto hacl