Set interpreter only when necessary #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the given interpreter is already set, nothing needs to be done. As with modifySoname(), it skips unnecessary processing.
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value to be written with
--set-intrepreterhas already been set,the operation can be skipped. Similar checks are already performed by
modifySoname()and can be implemented insetInterpreter().This may avoid the problem that segfaults occur after multiple calls to
patchelf --set-interpretermentioned in the link below.#492 (comment)
It also prevents the addition of unnecessary LOAD segments each time
patchelf --set-interpreteris called.