Extend LOAD segments by the size of the new section #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to investigate the reason for this comment
/* !!! Why do we stop after a .dynstr section? I can't remember! */I removed the condition, and investigated failing tests (many broke). This patch removes the condition and fixes the issues arising from it.
What happens is that without that condition we replace many more sections, making the size of the first LOAD segment insufficient to fit all sections. Also, the first LOAD segment might be read only, and we could be bringing in a section that requires writes.
I'm not sure if we should merge this. @Mic92 @cgzones this mainly goes to show the need to improve testability mentioned in #468