cope with maintainer entries using a non-github contact #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeuner
force-pushed
the
maintainer-record
branch
from
89fc5f7
to
85d9a30
Compare
13 tasks
13 tasks
2xsaiko
reviewed
Dec 20, 2023
| pkg.maintainers | ||
| (builtins.filter | ||
| (maintainer: | ||
| pkgs.lib.hasAttrByPath ["github"] maintainer) |
There was a problem hiding this comment.
Suggested change
| pkgs.lib.hasAttrByPath ["github"] maintainer) | |
| pkgs.lib.hasAttrByPath [ "github" ] maintainer) |
Apparently people like these spaces. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been discussion (NixOS/nixpkgs#273146 (comment)) implying that the current
ofborgimplementation may have issues coping with our year-long proven maintainer list data model, but I could not find a corresponding issue report. Therefore, I tried to come up with a fix that should help against thelistToPingfunction failing.If there are more details about the issues faced, sharing them would be shared. This might allow me to improve this PR.
Of course this does not replace the need to provide ping handlers for the other contact entry variants, which will be processed in separate PRs.