-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
zx: 7.2.3 -> 8.1.2 #309121
base: master
Are you sure you want to change the base?
zx: 7.2.3 -> 8.1.2 #309121
Conversation
@jlbribeiro there is currently breaking change restriction to all branches as per definition of breaking change #303285
I know it's a leaf package, but unless someone says otherwise, this will have to wait for after 24.05 release |
@kirillrdy That makes total sense, will have to wait then. This made me re-read the schedule and fully grasp the release cycle. (and again, thank you for the review + direction steering) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renewing my approval, but as mentioned above we should wait until 24.05
@getchoo Thank you. Can you confirm, however, that this should not be merged as-is after 24.05 is released, given it would modify the wrong release notes? (I'm validating whether I understood the release cycle "rules") |
correct
set PR to draft |
Diff: google/zx@7.2.3...8.1.2 Changelog: - https://github.com/google/zx/releases/tag/8.0.0 - https://github.com/google/zx/releases/tag/8.0.1 - https://github.com/google/zx/releases/tag/8.0.2 - https://github.com/google/zx/releases/tag/8.1.0 - https://github.com/google/zx/releases/tag/8.1.1 - https://github.com/google/zx/releases/tag/8.1.2 Fixes NixOS#309047.
Following NixOS#309047 (comment), I'm replacing @hlolli as zx maintainer.
Description of changes
Fixes #309047.
Changes maintainer to @jlbribeiro, following this comment by the current maintainer.
Given
zx
popularity and its usage as a shell scripting language, I assume it might be worth linking the 8.0.0 release changelog in the next NixOS release's notes.edit: As we're currently in feature freeze, I'm turning this PR into a draft, and will be updating the next release notes only when that document is created.
Diff: google/zx@7.2.3...8.1.2
Changelog:
Maintainer: @hlolli (currently), to become @jlbribeiro after merge
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.