Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

zx: 7.2.3 -> 8.1.2 #309121

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

zx: 7.2.3 -> 8.1.2 #309121

wants to merge 2 commits into from

Conversation

jlbribeiro
Copy link
Member

@jlbribeiro jlbribeiro commented May 4, 2024

Description of changes

Fixes #309047.
Changes maintainer to @jlbribeiro, following this comment by the current maintainer.

Given zx popularity and its usage as a shell scripting language, I assume it might be worth linking the 8.0.0 release changelog in the next NixOS release's notes.

edit: As we're currently in feature freeze, I'm turning this PR into a draft, and will be updating the next release notes only when that document is created.

Diff: google/zx@7.2.3...8.1.2

Changelog:

Maintainer: @hlolli (currently), to become @jlbribeiro after merge

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

pkgs/tools/system/zx/default.nix Outdated Show resolved Hide resolved
@kirillrdy
Copy link
Member

@jlbribeiro there is currently breaking change restriction to all branches

as per definition of breaking change #303285

Breaking change

A change that is likely to break downstream consumers

I know it's a leaf package, but unless someone says otherwise, this will have to wait for after 24.05 release

@jlbribeiro
Copy link
Member Author

@kirillrdy That makes total sense, will have to wait then. This made me re-read the schedule and fully grasp the release cycle.
If I fully understood, I'll have to move the release notes' update to the future 24.?? (not 24.05) release notes, correct?
(first time I noticed there's a release-YY.mm and nixos-YY.mm, was only aware of the latter)

(and again, thank you for the review + direction steering)

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renewing my approval, but as mentioned above we should wait until 24.05

@jlbribeiro
Copy link
Member Author

renewing my approval, but as mentioned above we should wait until 24.05

@getchoo Thank you.

Can you confirm, however, that this should not be merged as-is after 24.05 is released, given it would modify the wrong release notes? (I'm validating whether I understood the release cycle "rules")
Putting in in another way: did I understand correctly this package will not and must not reach the nixos-24.05, not even via a backport (as it would introduce breaking changes)? Just ensuring this doesn't get merged by mistake, given it's already approved. (couldn't find an appropriate label for this situation)

@kirillrdy
Copy link
Member

will not and must not reach the nixos-24.05, not even via a backport (as it would introduce breaking changes)

correct

Just ensuring this doesn't get merged by mistake

set PR to draft

@jlbribeiro jlbribeiro changed the title zx: 7.2.3 -> 8.0.2 zx: 7.2.3 -> 8.1.0 May 15, 2024
@jlbribeiro jlbribeiro changed the title zx: 7.2.3 -> 8.1.0 zx: 7.2.3 -> 8.1.1 May 23, 2024
@jlbribeiro jlbribeiro changed the title zx: 7.2.3 -> 8.1.1 zx: 7.2.3 -> 8.1.2 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants