fluent-gtk-theme: 2023-06-20 -> 2024-04-28 #307603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRTitor
reviewed
Apr 29, 2024
| @@ -23,13 +23,13 @@ lib.checkListOfEnum "${pname}: tweaks" [ "solid" "float" "round" "blur" "noborde | |||
|
|
|||
| stdenvNoCC.mkDerivation rec { | |||
| inherit pname; | |||
| version = "2023-06-20"; | |||
| version = "2024-04-28"; | |||
|
|
|||
| src = fetchFromGitHub { | |||
| owner = "vinceliuice"; | |||
| repo = pname; | |||
There was a problem hiding this comment.
Suggested change
| repo = pname; | |
| repo = "fluent-gtk-theme"; |
JohnRTitor
reviewed
Apr 29, 2024
| @@ -23,13 +23,13 @@ lib.checkListOfEnum "${pname}: tweaks" [ "solid" "float" "round" "blur" "noborde | |||
|
|
|||
| stdenvNoCC.mkDerivation rec { | |||
There was a problem hiding this comment.
Can you remove the recursion and move to finalAttrs?
romildo
force-pushed
the
upd.fluent-gtk-theme
branch
from
8c4eaf1
to
ee43d86
Compare
JohnRTitor
reviewed
Apr 29, 2024
| @@ -74,4 +74,4 @@ stdenvNoCC.mkDerivation rec { | |||
| platforms = platforms.unix; | |||
| maintainers = [ maintainers.romildo ]; | |||
There was a problem hiding this comment.
Remove with lib; and use the components explicitly when needed.
For this particular line:
Suggested change
| maintainers = [ maintainers.romildo ]; | |
| maintainers = with lib.maintainers; [ romildo ]; |
The rest can be prepended with lib.
romildo
force-pushed
the
upd.fluent-gtk-theme
branch
from
ee43d86
to
7a1aa5e
Compare
JohnRTitor
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update to version 2024-04-28
Closes #307512
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.