grocy: 4.0.3 -> 4.2.0, build from sources

[LeSuisse]

Description of changes

The adjusted patch have been taken from #288602.

Changes:
https://github.com/grocy/grocy/releases/tag/v4.1.0
https://github.com/grocy/grocy/releases/tag/v4.2.0

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package blacklisted:

• nixos-install-tools

1 package built:

• grocy

---

Add a 👍 reaction to pull requests you find important.

[LeSuisse]

cc @tebriel It might be of interest for you since you opened #288602

[wegank]

@ofborg build grocy

[diogotcorreia]

I've successfully built the package and ran the corresponding tests (x86_64 linux).
Additionally, I've ran the tests interactively and can validate that everything seems to be working visually as well:

[diogotcorreia]

I've done the same tests as before, things seems to (still) work fine.

I have, however, noticed that on nginx logs, it is complaining about the data/viewcache directory not existing.

machine # [   89.918347] nginx[799]: 2024/04/17 07:59:30 [error] 799#799: *31 FastCGI sent in stderr: "PHP message: PHP Warning:  Base directory /nix/store/50q0mswdxi6lg412rr2da5i19yvkrys5-grocy-4.2.0/public/../data/viewcache does not exist,
machine # [   89.921235] nginx[799]:                     please create or change using %Cache.SerializerPath in /nix/store/50q0mswdxi6lg412rr2da5i19yvkrys5-grocy-4.2.0/packages/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer.php on line 232; PHP message: PHP Warning:  Base directory /nix/store/50q0mswdxi6lg412rr2da5i19yvkrys5-grocy-4.2.0/public/../data/viewcache does not exist,

I've tried to see if this was present in the version in master, and it seems like the directory exists but (obviously) it is not writable:

machine # [ 3998.407026] nginx[800]: 2024/04/17 09:19:58 [error] 800#800: *7 FastCGI sent in stderr: "PHP message: PHP Warning:  Directory /nix/store/mmdcj83if1qnhj4j6qj7vlag0mg7psgm-grocy-4.0.3/public/../data/viewcache not writable, please chmod to 777 in /nix/store/mmdcj83if1qnhj4j6qj7vlag0mg7psgm-grocy-4.0.3/packages/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer.php on line 294; PHP message: PHP Warning:  Directory /nix/store/mmdcj83if1qnhj4j6qj7vlag0mg7psgm-grocy-4.0.3/public/../data/viewcache not writable, please chmod to 777 in /nix/store/mmdcj83if1qnhj4j6qj7vlag0mg7psgm-grocy-4.0.3/packages/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer.php on line 294; PHP message: PHP Warning:  Directory /nix/store/mmdcj83if1qnhj4j6qj7vlag0mg7psgm-grocy-4.0.3/public/../data/viewcache not writable, please chmod to 777 in /nix/store/mmdcj83if1qnhj4j6qj7vlag0mg7psgm-grocy-4.0.3/packages/ezyang/htmlpurifier/library/HTMLPurifier/DefinitionCache/Serializer.php on line 294" while reading response header from upstream, client: 10.0.2.2, server: localhost, request: "PUT /api/user/settings/datatables_state_stock-overview-table HTTP/1.1", upstream: "fastcgi://unix:/run/phpfpm/grocy.sock:", host: "localhost:8080", referrer: "http://localhost:8080/stockoverview"

I wouldn't call it a regression since it was not working before either, but it would be nice to fix it either way (I'm guessing it might require patching?)

[LeSuisse]

I wouldn't call it a regression since it was not working before either, but it would be nice to fix it either way (I'm guessing it might require patching?)

Fixed.

[diogotcorreia]

LGTM, thanks for fixing all the issues :)

(Tested everything again, it's all working)

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1596

[wegank]

4 neutral checks, doesn't look good?

[diogotcorreia]

Hm I missed that, sorry
Last time I tried the tests locally they worked on my machine
@LeSuisse could you take a look?

EDIT: still builds for me, no idea what's wrong.
The error in OfBorg is /nix/store/zykyv2faxz6s1l2pdn6i7i5hb5r5wri6-stdenv-linux/setup: line 1582: fixup-yarn-lock: command not found

[LeSuisse]

Done, I missed #281902 after my last rebase.

[diogotcorreia]

@LeSuisse seems to still be failing on darwin, now sure if it's supposed to, but I have no way to test

[LeSuisse]

Does not seem to be directly related to this change, the error does not come from the grocy derivation which is the only touched here.

error: a 'x86_64-linux' with features {} is required to build '/nix/store/033j5c2xsbz7qw4pbvvpj7xmzl0ijdrb-audit-disable.drv', but I am a 'x86_64-darwin' with features {benchmark, big-parallel, nixos-test}

error: a 'aarch64-linux' with features {} is required to build '/nix/store/zz5knj1m69pmn42fvsmjvcsp4psyxhpv-append-initrd-secrets.drv', but I am a 'aarch64-darwin' with features {benchmark, big-parallel, nixos-test}

[diogotcorreia]

The checks seem to have passed in the latest version: https://github.com/NixOS/nixpkgs/runs/16724617034

Maybe it's related to buildComposerProject?
Judging by other packages using it (firefly-iii), seems like so: https://github.com/NixOS/nixpkgs/runs/23906932987

[diogotcorreia]

Excluding the darwin builds (which I don't think are related to this PR), everything seems to build and work on my PC (tested stuff again).

[wegank]

Result of nixpkgs-review pr 296686 run on aarch64-darwin 1

1 package built:

• grocy