Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nut: 2.7.4 -> 2.8.0" #242384

Closed
wants to merge 1 commit into from
Closed

Conversation

cyounkins
Copy link
Contributor

Description of changes

The change in #215890 didn't change the sha256 so the version and hash do not match. While I'm excited to land version 2.8.0, we should revert the version number until we can get a solid PR for it.

Ofborg issue asking if we can detect this condition: NixOS/ofborg#647

This should be backported to the 23.05 branch, but I'm unsure how to do that.

@markuskowa

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

The preferred way is to use git revert 47cfb7f0906f3cb877aa9a9c348ca8709deec141,
to clarify it in the git history.

@cyounkins cyounkins changed the title nut: revert version bump Revert "nut: 2.7.4 -> 2.8.0" Jul 9, 2023
@cyounkins
Copy link
Contributor Author

Yeah, that works too. I had wanted to keep the URL interpolation portion, but it's not a big deal. Should be good now.

@SuperSandro2000
Copy link
Member

redundant with #233031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants