Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: Remove test #223903

Merged
merged 1 commit into from
Mar 30, 2023
Merged

cypress: Remove test #223903

merged 1 commit into from
Mar 30, 2023

Conversation

roberth
Copy link
Member

@roberth roberth commented Mar 30, 2023

Description of changes

We used to have a test for cypress, but I'm removing it as

cc cypress maintainers @thorstenweber83 @mmahut @Craftzman7

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Craftzman7
Copy link
Member

After reading through your reasons for changing this, I agree completely. This has the green light from me.

@roberth roberth merged commit 9fc93c5 into NixOS:master Mar 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants