Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raspberry-pi/5: init #927

Merged
merged 7 commits into from May 6, 2024
Merged

raspberry-pi/5: init #927

merged 7 commits into from May 6, 2024

Conversation

leo60228
Copy link
Member

Description of changes

Add necessary configuration for the Raspberry Pi 5. More detailed documentation is on the wiki.

Supersedes NixOS/nixpkgs#284391.

Things done
  • Tested the changes in your own NixOS Configuration
  • Tested the changes end-to-end by using your fork of nixos-hardware and
    importing it via <nixos-hardware> or Flake input

Copy link
Member

@nvmd nvmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I'm also working on bringing at least some level of support to RPi5 until upstream support is there, we definitely need to start somewhere with moving/adding 5's support to nixos-hardware.

raspberry-pi/5/default.nix Show resolved Hide resolved
raspberry-pi/5/overlay.nix Outdated Show resolved Hide resolved
Co-authored-by: Sergey Kazenyuk <kazenyuk@pm.me>
README.md Show resolved Hide resolved
@malteneuss
Copy link
Contributor

@nvmd Do you have rights to merge?

@nvmd
Copy link
Member

nvmd commented May 1, 2024

No, I don't, even if I had I would ask for a feedback more active members as well, whether this PR "fits" in its current state.
It will technically work, but considering the "push" from nixpkgs, maybe a more general approach for "pulling" this vendor's support to nixos-hardware should be taken.
E.g. the dependence on the nixpkgs for a vendor kernel doesn't look ideal, this is where better decoupling could be achieved.

raspberry-pi/5/overlay.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented May 6, 2024

@mergify queue

Copy link
Contributor

mergify bot commented May 6, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 8a4adfe

@mergify mergify bot merged commit 8a4adfe into NixOS:master May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants