Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input::fetchToStore(): Don't try to substitute #10612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Input::fetchToStore(): Don't try to substitute #10612

wants to merge 1 commit into from

Commits on Apr 26, 2024

  1. Input::fetchToStore(): Don't try to substitute 

    Having a narHash doesn't mean that we have the other attributes
returned by the fetcher (such as lastModified or rev). For instance,

   $ nix flake metadata github:NixOS/patchelf/7c2f768bf9601268a4e71c2ebe91e2011918a70f
   Last modified: 2024-01-15 10:51:22

but

   $ nix flake metadata github:NixOS/patchelf/7c2f768bf9601268a4e71c2ebe91e2011918a70f?narHash=sha256-PPXqKY2hJng4DBVE0I4xshv/vGLUskL7jl53roB8UdU%3D
   (does not print a "Last modified")

The latter only happens if the store path already exists or is
substitutable, which made this impure behaviour unpredictable.

Fixes NixOS#10601.
    @edolstra
    edolstra committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    ff107d9 View commit details
    Browse the repository at this point in the history