fetchToStore(): Avoid duplicate copying if the input is already a store path #10511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
fetching
Ericson2314
approved these changes
Apr 15, 2024
Ericson2314
reviewed
Apr 15, 2024
| // an FSInputAccessor pointing to a store path. | ||
| if (path.accessor->isStorePath | ||
| && path.path.isRoot() | ||
| && method == FileIngestionMethod::Recursive |
There was a problem hiding this comment.
What goes wrong if we skip this? I am trying to special-case NAR hashing less in Nix currently.
Suggested change
| && method == FileIngestionMethod::Recursive |
Ericson2314
requested changes
Apr 15, 2024
We do need that to ensure it's only used for store paths where we know their ingestion method. As mentioned above, the architecturally cleaner way is to make |
|
I think I rather solve this in a different way:
I am still hoping |
|
If you could take a stab at #10467 (review) @edolstra, I would be happy to take on this one per my plan above. |
This was referenced Apr 15, 2024
…re path This is needed for the path:// input scheme (until it returns a FSInputAccessor to the original path, but that's blocked by NixOS#10089) and the Mercurial input scheme.
edolstra
force-pushed
the
optimize-fetchToStore
branch
from
893c383
to
8d08846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is needed for the path:// input scheme (until it returns a
FSInputAccessorto the original path, but that's blocked by #10089) and the Mercurial input scheme.Note: it would be cleaner to have
fetchToStore()as an overridable method onInputAccessor(as was originally the case), but the latter got moved tolibutilso we can't do that anymore.Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.