Slight refactors in preparation for #10480 #10494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code operating on store objects (including creating them) should, in general, use `ContentAddressMethod` rather than `FileIngestionMethod`. See also dfc8765 which included some similar refactors.
Ericson2314
commented
Apr 13, 2024
| @@ -2395,7 +2394,9 @@ static void prim_path(EvalState & state, const PosIdx pos, Value * * args, Value | |||
| else if (n == "filter") | |||
| state.forceFunction(*(filterFun = attr.value), attr.pos, "while evaluating the `filter` parameter passed to builtins.path"); | |||
| else if (n == "recursive") | |||
| method = FileIngestionMethod { state.forceBool(*attr.value, attr.pos, "while evaluating the `recursive` attribute passed to builtins.path") }; | |||
There was a problem hiding this comment.
Casting a bool is bad for relying on internal representation details too much, so I made it more explicit.
roberth
requested changes
Apr 14, 2024
There was a problem hiding this comment.
I can't easily infer why this is an improvement, based on the documentation of the ContentAddressMethod and FileIngestionMethod types.
Specifically, it'd be good to describe how they relate, and perhaps add some guidance on which to pick, if we even need both.
|
Hehe very fair. #10479 and a follow-up for store object content addressing are supposed to finally, thoroughly answer that question. OK leaving this open until they are done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Code operating on store objects (including creating them) should, in general, use
ContentAddressMethodrather thanFileIngestionMethod.Context
#10480
See also dfc8765 which included some similar refactors.
Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.