Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add gene expression routes and views. #806

Merged
merged 5 commits into from Aug 11, 2023
Merged

Conversation

rwblair
Copy link
Member

@rwblair rwblair commented Aug 10, 2023

I believe these were removed originally because we couldn't get the ahba docker image to build. I was able to get the preparing_AHBA_data.py script to run, but the df.drop removing coordinates outside of the brain caused key errors. changing the drop to use errors='ignore' allowed script to run to completion and produced a store_max1_reduced.h5 that was about the same size as the old one, but according to h5diff contained many differences. Opting to use old version of it.

@rwblair
Copy link
Member Author

rwblair commented Aug 11, 2023

upgrading to nibabel 5.1 causes issues with nidmresults and nidmresults-fsl. Looking into patching these.

@rwblair
Copy link
Member Author

rwblair commented Aug 11, 2023

Dropping down to nibabel 4 gets all but one of the tests to pass. Issues are around nidmresults which need to be fixed on their own anyways.

@rwblair rwblair merged commit 7a61f13 into master Aug 11, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant