Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] add github actions #767

Merged
merged 38 commits into from
Apr 11, 2023
Merged

[CI] add github actions #767

merged 38 commits into from
Apr 11, 2023

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Oct 31, 2022

closes #760

@jdkent jdkent changed the title add github ci [CI] add github actions Nov 1, 2022
@jdkent
Copy link
Contributor Author

jdkent commented Nov 1, 2022

looks like neurovault image is still dependent on pybraincompare to run, is this a package we are keeping?

Upgrade NeuroVault & revive deployment
@jdkent
Copy link
Contributor Author

jdkent commented Apr 6, 2023

removed the current ci file and replaced it with the one I was working on.
building and caching work. I had to change the docker build process to make it such that the freesurfer build of neurovault would build after the original neurovault docker image was built (using multistage building). This could change how production would be implemented.

I think there a couple changes to be made before we make this deployable to production

  • tag builds with releases
  • restructure production.yml to use the prebuilt images on this repository

Otherwise this is working/ready for review.

Copy link
Contributor

@adelavega adelavega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll let ross take a look, but let's merge this soon so we can make other changes

@@ -4,7 +4,8 @@ services:
restart: always
build:
context: .
dockerfile: ./compose/django/Dockerfile_fs
dockerfile: ./compose/django/Dockerfile_multi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need 2 Docker files?

@adelavega
Copy link
Contributor

Currently the multistage build i used for CI, but we have not currently adopting it for production

@rwblair rwblair merged commit 6744e3a into upgrade Apr 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants