-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] add github actions #767
Conversation
looks like neurovault image is still dependent on pybraincompare to run, is this a package we are keeping? |
Upgrade NeuroVault & revive deployment
removed the current ci file and replaced it with the one I was working on. I think there a couple changes to be made before we make this deployable to production
Otherwise this is working/ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll let ross take a look, but let's merge this soon so we can make other changes
@@ -4,7 +4,8 @@ services: | |||
restart: always | |||
build: | |||
context: . | |||
dockerfile: ./compose/django/Dockerfile_fs | |||
dockerfile: ./compose/django/Dockerfile_multi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need 2 Docker files?
Currently the multistage build i used for CI, but we have not currently adopting it for production |
closes #760