Added CHUNK_FILL_COST #6983
Open
Added CHUNK_FILL_COST #6983
+800
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishqjasoria
requested changes
May 6, 2024
| @@ -52,6 +52,11 @@ public class VerkleWorldState : IWorldState | |||
| // // False positives would be problematic as the code _must_ be persisted | |||
| private readonly LruKeyCache<Hash256> _codeInsertFilter = new(2048, "Code Insert Filter"); | |||
|
|
|||
| public byte[]? GetValue(Hash256 key) | |||
There was a problem hiding this comment.
here we only need this to check if the value is present or not - so we dont need to actually return the value
you can just return true and false and have a funciton like ValuePresentInTree
Also, you can add similar functions in the tree also, to just check presence - this will be much faster then finding and returning the value
| @@ -136,7 +136,8 @@ protected virtual TransactionResult Execute(Transaction tx, in BlockExecutionCon | |||
| if (commit) WorldState.Commit(spec, tracer.IsTracingState ? tracer : NullTxTracer.Instance); | |||
|
|
|||
| // declare the execution witness to collect witness and also charge gas | |||
| IExecutionWitness executionWitness = spec.IsVerkleTreeEipEnabled ? new VerkleExecWitness(LogManager) : new NoExecWitness(); | |||
| var verkleWorldState = WorldState as VerkleWorldState; | |||
There was a problem hiding this comment.
we need some kind of error handling here or inside VerkleExecWitness class.
make the input nullable and then check in the constructor, if the value is null - throw an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6961
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.