Flat file blocks #6976
Draft
Flat file blocks #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
May 3, 2024
| private void SaveToFile(Block block) | ||
| { | ||
| (string directory, string filename, int lockId) = GetBlockDirectoryAndPath(block.Number, _basePath); | ||
| RecyclableMemoryStream output = RecyclableStream.GetStream(filename); |
| Directory.CreateDirectory(directory); | ||
| } | ||
|
|
||
| FileStream file = new(path, mode: FileMode.OpenOrCreate, access: FileAccess.Write, share: FileShare.Read); |
There was a problem hiding this comment.
you could FIleShare ReadWrite if you read non-locked block numbers?
| RecyclableRlpStream rlpStream; | ||
| if (item is null) | ||
| { | ||
| rlpStream = new RecyclableRlpStream(tag); |
There was a problem hiding this comment.
this can be moved outside if?
Comment on lines
+266
to
+299
| path = Path.Combine(directory, filename); | ||
| } | ||
| if (path is not null && File.Exists(path)) | ||
| { | ||
| using FileStream file = new(path, mode: FileMode.Open, access: FileAccess.Read, share: FileShare.ReadWrite); | ||
| var fileHandle = file.SafeFileHandle; | ||
| long headerOffset = (blockNumber / FileSplit) % BlocksPerFile; | ||
|
|
||
| Vector128<long> headerEntry = default; | ||
| Span<byte> headerData = MemoryMarshal.AsBytes(MemoryMarshal.CreateSpan(ref headerEntry, 1)); | ||
| long read = RandomAccess.Read(fileHandle, headerData, Vector128<byte>.Count * headerOffset); | ||
| if (read == Vector128<byte>.Count && headerEntry != default) | ||
| { | ||
| long offset = headerEntry.GetElement(0); | ||
| int length = (int)headerEntry.GetElement(1); | ||
|
|
||
| var array = ArrayPool<byte>.Shared.Rent(length); | ||
| try | ||
| { | ||
| var input = array.AsSpan(0, length); | ||
| read = RandomAccess.Read(fileHandle, input, offset); | ||
| if (read == length) | ||
| { | ||
| using RecyclableMemoryStream outputStream = RecyclableStream.GetStream(filename); | ||
| var compressed = new MemoryStream(array, 0, length, writable: false); | ||
| using (SnappyStream decompressor = new(compressed, CompressionMode.Decompress)) | ||
| { | ||
| decompressor.CopyTo(outputStream); | ||
| } | ||
|
|
||
| ArrayPool<byte>.Shared.Return(array); | ||
| array = null; | ||
|
|
||
| outputStream.Position = 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.