EIP-7667: Update gas costs #6932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
requested changes
Apr 18, 2024
tanishqjasoria
requested changes
Apr 19, 2024
There was a problem hiding this comment.
you can refer to changes in Nethermind.Specs here to understand the changes that are needed for parsing json.
for BLAKE2 gas, update BLAKE2_GFROUND cost.
ref: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-152.md
LukaszRozmej
approved these changes
Apr 22, 2024
tanishqjasoria
requested changes
Apr 24, 2024
tanishqjasoria
requested changes
Apr 25, 2024
|
|
||
| namespace Nethermind.Evm.Test; | ||
|
|
||
| public class Eip7667Spec : Cancun |
There was a problem hiding this comment.
just rename this to Prague and move this to Nethermind.Specs/Forks
| public class Eip7667Tests : VirtualMachineTestsBase | ||
| { | ||
| [SetUp] | ||
| public void SetUp() |
There was a problem hiding this comment.
you can remove this - the base class function will anyways be called
Comment on lines
66
to
82
| public void Keccak256OpDifference() | ||
| { | ||
| byte[] code = Prepare.EvmCode | ||
| .PushData(32) | ||
| .PushData(0) | ||
| .Op(Instruction.KECCAK256) | ||
| .STOP() | ||
| .Done; | ||
|
|
||
| TestAllTracerWithOutput resultEipDisabled = Execute((ForkActivation)1, code); | ||
| Setup(); | ||
| TestAllTracerWithOutput resultEipEnabled = Execute((ForkActivation)2, code); | ||
|
|
||
| long gasDifference = Eip7667Spec.Instance.GetSha3Cost() - Cancun.Instance.GetSha3Cost() | ||
| + Eip7667Spec.Instance.GetSha3WordCost() - Cancun.Instance.GetSha3WordCost(); | ||
|
|
||
| Assert.That(resultEipEnabled.GasSpent - resultEipDisabled.GasSpent, Is.EqualTo(gasDifference)); |
There was a problem hiding this comment.
just have a look at how other test works regarding checking values before and after. implement this similarly. EIP3651Tests can be a good reference for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
#6924
Changes
Update gas cost for opcodes and precompiles mentioned in EIP-7667
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.