Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-7685 Implementation #6905

Open
wants to merge 173 commits into
base: master
Choose a base branch
from
Open

EIP-7685 Implementation #6905

wants to merge 173 commits into from

Conversation

rjnrohit
Copy link
Contributor

@rjnrohit rjnrohit commented Apr 8, 2024

Fixes Closes Resolves #6387

Changes

This PR implements the following EIPs:

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@MarekM25 MarekM25 dismissed their stale review May 2, 2024 22:54

dismiss

@rjnrohit
Copy link
Contributor Author

rjnrohit commented May 3, 2024

Does ConsensusRequest need to be serialized to RLP (they are not in BlockBodies)? Do they need to be transmitted through network? That would probably need an RLP change and new eth/XX version? Do they need to be sent through RPC?
Basicly are they transient - just to reply once per NewPayload, or do we need to store them somehow?

They are in block body, we haven't added them to BlockBodyMessageSerializer. @rjnrohit is working on it. They are not transient. They are similar to withdrawals. We need to store them. About RPC - I think they are part of block so it should be in RPC as well. I think we don't need a new version of eth/XX. They need to be transmitted through network

Added!

Comment on lines 17 to 36
[JsonIgnore]
public ConsensusRequestsType Type { get; protected set; }

[JsonIgnore]
public ulong AmountField { get; protected set; }

[JsonIgnore]
public Address? SourceAddressField { get; protected set; }

[JsonIgnore]
public byte[]? PubKeyField { get; set; }

[JsonIgnore]
public byte[]? WithdrawalCredentialsField { get; protected set; }

[JsonIgnore]
public byte[]? SignatureField { get; protected set; }

[JsonIgnore]
public ulong? IndexField { get; protected set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do it as a proper JSON class hierarchy? With ConsensusRequestsType being a discriminating field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype & implement EIP-7002: Execution layer triggerable exits
5 participants