New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7685 Implementation #6905
base: master
Are you sure you want to change the base?
EIP-7685 Implementation #6905
Conversation
+ add missing checks
Added! |
src/Nethermind/Nethermind.Consensus/Requests/DepositsProcessor.cs
Outdated
Show resolved
Hide resolved
[JsonIgnore] | ||
public ConsensusRequestsType Type { get; protected set; } | ||
|
||
[JsonIgnore] | ||
public ulong AmountField { get; protected set; } | ||
|
||
[JsonIgnore] | ||
public Address? SourceAddressField { get; protected set; } | ||
|
||
[JsonIgnore] | ||
public byte[]? PubKeyField { get; set; } | ||
|
||
[JsonIgnore] | ||
public byte[]? WithdrawalCredentialsField { get; protected set; } | ||
|
||
[JsonIgnore] | ||
public byte[]? SignatureField { get; protected set; } | ||
|
||
[JsonIgnore] | ||
public ulong? IndexField { get; protected set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do it as a proper JSON class hierarchy? With ConsensusRequestsType
being a discriminating field?
Fixes Closes Resolves #6387
Changes
This PR implements the following EIPs:
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.