New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blob gas fee collection for Gnosis #6866
base: master
Are you sure you want to change the base?
Conversation
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
Btw the functionality requires a fork and can't merged without it |
Right! We need a chainspec timestamp activation flag for it then! |
@@ -73,6 +73,7 @@ | |||
"eip4844TransitionTimestamp": "0x65ba8e4c", | |||
"eip5656TransitionTimestamp": "0x65ba8e4c", | |||
"eip6780TransitionTimestamp": "0x65ba8e4c", | |||
"gipxyzTransitionTimestamp": "0x65efbeef", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not enabling anything yet, so I would say remove it for now, unless this is not mergeable until time is decided
@@ -79,6 +79,7 @@ | |||
"eip4844TransitionTimestamp": "0x65ef4dbc", | |||
"eip5656TransitionTimestamp": "0x65ef4dbc", | |||
"eip6780TransitionTimestamp": "0x65ef4dbc", | |||
"gipxyzTransitionTimestamp": "0x65efbeef", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not enabling anything yet, so I would say remove it for now
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Needs changes to hive tests.
Documentation
Requires documentation update
Requires explanation in Release Notes