inject jvm options #1089
Merged
inject jvm options #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upsert uses commas as the delimiter between options which
doesn't work for a few C* options that use commas in the value.
Inject works by takign the string and adding it to the end of the jvm-server.options
file verbatim. While the comments in that file say it expects one option per line
there is nothign that actually enforces that rule. The line only needs to start with a '-'
Code that parses the options file:
JVM_OPTS_FILE=$CASSANDRA_CONF/jvm${jvmoptions_variant:--clients}.options
if [ $JAVA_VERSION -ge 11 ] ; then
JVM_DEP_OPTS_FILE=$CASSANDRA_CONF/jvm11${jvmoptions_variant:--clients}.options
else
JVM_DEP_OPTS_FILE=$CASSANDRA_CONF/jvm8${jvmoptions_variant:--clients}.options
fi
for opt in `grep "^-" $JVM_OPTS_FILE` `grep "^-" $JVM_DEP_OPTS_FILE`
do
JVM_OPTS="$JVM_OPTS $opt"
done
jrwest
force-pushed
the
jwest/inject-jvm-options
branch
from
e1017ea
to
eed6f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upsert uses commas as the delimiter between options which doesn't work for a few C* options that use commas in the value.
Inject works by taking the string and adding it to the end of the jvm-server.options file verbatim. While the comments in that file say it expects one option per line there is nothing that actually enforces that rule. The line only needs to start with a '-'
Code that parses the options file: