Remove Backup Version V1 #1082
Merged
Remove Backup Version V1 #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| .findFirst(); | ||
| Assert.assertTrue(backupMetadata.isPresent()); | ||
| Assert.assertNull(backupMetadata.get().getLastValidated()); | ||
| backupStatusMgr.finish(getBackupMetaData(start, Status.FINISHED)); | ||
| } | ||
|
|
||
| @Test | ||
| public void verifyBackupVersion1DateRange() throws Exception { |
There was a problem hiding this comment.
It will be good if we can update the function name(remove version1) or remove this test completely as v2 test is already present in verifyBackupVersion2DateRange
There was a problem hiding this comment.
Agreed. The test is redundant and should be removed. I will do that in a follow-up.
| @@ -212,11 +212,6 @@ public String getMaxDirectMemory() { | |||
| (PRIAM_PRE + ".direct.memory.size.") + instanceInfo.getInstanceType(), "50G"); | |||
| } | |||
|
|
|||
| @Override | |||
| public String getBackupCronExpression() { | |||
There was a problem hiding this comment.
It was only referenced in SnapshotBackup which was removed in this cleanup. The modern equivalent is getSnapshotMetaServiceCronExpression() used in SnapshotMetaTask.
chengw-netflix
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits are meant to be reviewed in order to keep the process tractable.
Remove unused CLI tools.
Remove tooling to back up commit logs. It is no longer supported.
Remove IFileSystemContext. It is redundant.
Remove BackupService
Remove BackupVersion.
Remove GCS-specific code. It is no longer in use.
Remove remaining vestiges of backup v1.