Backports to get 3.x aligned with 3.11 #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1034) * Remove metaproxy validation it is never null in practice. * Remove DateRange validation. It is never null in practice. * Remove debug logging. * Remove latest backup metadata validation. It is never null in practice. * Consolidate repeated code into private verifyBackup. * Change method names to better reflect what they do. * Update latestResult wherever possible. * Rewrite logic in findLatestVerfiedBackup to make it look more like verifyBackupsInRange. * Change signature of BackupNotificationMgr.notify to not depend on BackupVerificationResult. * Return all verified BackupMetadata instead of BackupVerificationResult when verifying en masse. It has enough information to skip the call to find the most recently verified backup. Also, fix some tests that broke in this process: remove the check for the snapshot time in TestBackupVerification that only makes sense when the Path is for a file that does not exist. Also, mock the appropriate functions in MockBackupVerification in TestBackupVerificationTask. * Rename findLatestVerifiedBackup responding to review comments.
…pshot (#1035) * Remove unused code. * Remove redundant comments and vertical whitespace. * Remove debug comments and now-redundant logger, simplify if-else and tighten error message for code style. * Use final where applicable and remove it where redundant. * Remove redundant BackupRestoreException from getIncrementals method signature. * Split getting incremental files and snapshot files into separate methods. * Reveal hook to allow operators to restore to the last valid snapshot. * Remove added non-shaded Guava dependency pursuant to review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7247964 2023-04-15 | Always TTL backups. (#1038) (HEAD -> 3.11, origin/3.11) [mattl-netflix]
05900e4 2023-04-11 | remove the instance info from the DI (#1042) [Cheng Wang]
c489748 2023-03-30 | make the constructor public [Cheng Wang]
f48fc9e 2023-03-29 | minor code modifications to simplify the nfpriam spring boot migration (origin/chengw/fix-for-sbn) [Cheng Wang]
36321c4 2023-03-29 | Reveal hook to allow operators to restore just to the most recent snapshot (#1035) [mattl-netflix]
0fb87f9 2023-03-27 | Fix backup verification race condition causing missing notifications (#1034) [mattl-netflix]