Fix Github CI by explicitly creating necessary directories. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattl-netflix
added a commit
that referenced
this pull request
Apr 18, 2023
mattl-netflix
added a commit
that referenced
this pull request
Apr 18, 2023
* Fix backup verification race condition causing missing notifications (#1034) * Remove metaproxy validation it is never null in practice. * Remove DateRange validation. It is never null in practice. * Remove debug logging. * Remove latest backup metadata validation. It is never null in practice. * Consolidate repeated code into private verifyBackup. * Change method names to better reflect what they do. * Update latestResult wherever possible. * Rewrite logic in findLatestVerfiedBackup to make it look more like verifyBackupsInRange. * Change signature of BackupNotificationMgr.notify to not depend on BackupVerificationResult. * Return all verified BackupMetadata instead of BackupVerificationResult when verifying en masse. It has enough information to skip the call to find the most recently verified backup. Also, fix some tests that broke in this process: remove the check for the snapshot time in TestBackupVerification that only makes sense when the Path is for a file that does not exist. Also, mock the appropriate functions in MockBackupVerification in TestBackupVerificationTask. * Rename findLatestVerifiedBackup responding to review comments. * Reveal hook to allow operators to restore just to the most recent snapshot (#1035) * Remove unused code. * Remove redundant comments and vertical whitespace. * Remove debug comments and now-redundant logger, simplify if-else and tighten error message for code style. * Use final where applicable and remove it where redundant. * Remove redundant BackupRestoreException from getIncrementals method signature. * Split getting incremental files and snapshot files into separate methods. * Reveal hook to allow operators to restore to the last valid snapshot. * Remove added non-shaded Guava dependency pursuant to review comments. * minor code modifications to simplify the nfpriam spring boot migration * make the constructor public * remove the instance info from the DI (#1042) * Always TTL backups. (#1038) * Fix Github CI by explicitly creating necessary directories. (#1045) --------- Co-authored-by: Cheng Wang <chengw@netflix.com> Co-authored-by: Cheng Wang <107727158+chengw-netflix@users.noreply.github.com>
mattl-netflix
added a commit
that referenced
this pull request
Jul 13, 2023
mattl-netflix
added a commit
that referenced
this pull request
Sep 6, 2023
mattl-netflix
added a commit
that referenced
this pull request
Sep 15, 2023
* Remove redundant interfaces and swap log and notification lines (#1019) * Remove EventGenerator Interface. * Remove EventObserver Interface. * Remove BackupEvent Interface. * Send SNS notification on backup after logging to account for the possibility of an Exception while trying to notify. * Use synchronized list for thread-safety (#1018) This list of PartETag is modified on multiple threads, so it needs to be thread-safe. S3FileSystem already uses a synchronized list, so do the same here. * Log backup failures rather than ignoring them. (#1025) * Update CHANGELOG in advance of 3.11.95 * Print cleaner stack trace on failure to upload. (#1027) * Switch from com.google.inject to JSR-330 javax.inject annotations for better compatibility * Update CHANGELOG.md * Reveal property to enable auto_snapshot. (#1031) * Fix backup verification race condition causing missing notifications (#1034) * Remove metaproxy validation it is never null in practice. * Remove DateRange validation. It is never null in practice. * Remove debug logging. * Remove latest backup metadata validation. It is never null in practice. * Consolidate repeated code into private verifyBackup. * Change method names to better reflect what they do. * Update latestResult wherever possible. * Rewrite logic in findLatestVerfiedBackup to make it look more like verifyBackupsInRange. * Change signature of BackupNotificationMgr.notify to not depend on BackupVerificationResult. * Return all verified BackupMetadata instead of BackupVerificationResult when verifying en masse. It has enough information to skip the call to find the most recently verified backup. Also, fix some tests that broke in this process: remove the check for the snapshot time in TestBackupVerification that only makes sense when the Path is for a file that does not exist. Also, mock the appropriate functions in MockBackupVerification in TestBackupVerificationTask. * Rename findLatestVerifiedBackup responding to review comments. * Reveal hook to allow operators to restore just to the most recent snapshot (#1035) * Remove unused code. * Remove redundant comments and vertical whitespace. * Remove debug comments and now-redundant logger, simplify if-else and tighten error message for code style. * Use final where applicable and remove it where redundant. * Remove redundant BackupRestoreException from getIncrementals method signature. * Split getting incremental files and snapshot files into separate methods. * Reveal hook to allow operators to restore to the last valid snapshot. * Remove added non-shaded Guava dependency pursuant to review comments. * minor code modifications to simplify the nfpriam spring boot migration * Update CHANGELOG.md * Update CHANGELOG.md * make the constructor public * Update CHANGELOG.md * remove the instance info from the DI (#1042) * Update CHANGELOG.md * Always TTL backups. (#1038) * Fix Github CI by explicitly creating necessary directories. (#1045) * Change the interface of PriamScheduler (#1049) Change the interface of PriamScheduler * minor name change (#1051) * Update CHANGELOG.md * Increment cross regional duplicate tokens to replicate the policy we have been applying manually. (#1048) * Increment cross regional duplicate tokens to replicate the policy we have been applying manually. Throw when duplicate tokens are created in region because that would be an obvious error and we should not add two nodes in the same region so closely together. * Improve error message on intra-regional duplicate token. * Update CHANGELOG in advance of 3.11.101 * Rollback #1042: Change the interface of EC2RoleAssumptionCredential (#1052) * Fix snapshot location regression in SNS messages. (#1054) * Update CHANGELOG in advance of 3.11.103 * change the CassandraMonitor to public (#1056) * Update CHANGELOG.md * Add new constructor (#1064) * Update CHANGELOG.md * Add disk_failure_policy config (#1065) * Update CHANGELOG.md * fix Gson serilization issue (#1067) * Update CHANGELOG.md * Make block_for_peers_timeout_in_secs a first-class tunable. (#1069) * Update CHANGELOG in advance of 3.11.108 * Fix TokenRetrieverTest --------- Co-authored-by: Ammar Khaku <akhaku@users.noreply.github.com> Co-authored-by: Cheng Wang <chengw@netflix.com> Co-authored-by: Cheng Wang <107727158+chengw-netflix@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.