Force the planner to use a certain instance type #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolynch
requested changes
Feb 10, 2023
| @@ -365,16 +374,17 @@ def _plan_certain( | |||
|
|
|||
| plans = [] | |||
| for instance in hardware.instances.values(): | |||
| exact_match = instance.family_separator in instance.family | |||
There was a problem hiding this comment.
This will always return true false. I think you want to do the for loop like I suggested inside the method against the strings in instance_families
There was a problem hiding this comment.
@jolynch - Does it make sense to have separate functions?
def _allow_instance
and
def _allow_drives
We use this function for the disk drives below on line 377. Should we keep this change specific to instance?
https://github.com/Netflix-Skunkworks/service-capacity-modeling/blob/main/service_capacity_modeling/capacity_planner.py#L377
| @@ -578,4 +588,4 @@ def _sub_models( | |||
|
|
|||
|
|
|||
| planner = CapacityPlanner() | |||
| planner.register_group(netflix.models) | |||
| planner.register_group(netflix.models) | |||
There was a problem hiding this comment.
nitpick: add back in a newline (UNIX mode not Windows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.