Dynamic luks support #850
Draft
Dynamic luks support #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable setting the luks option in a volume config based on the parameters from the create volume request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable setting the luks option in a volume config based on the parameters from the create volume request
To address #849, we followed an approach where we parse the selectors from the create volume request. After that is done, we get the
luksselector, and if it has a value, we assigned it to the volume config. To keep previous functionality, if this value is not set, it will be set to the default from the backend in the ontap san driver.An issue with this approach is that even though in the NetApp luks documentation this same label is used, an user may use a different label instead of
luks.We implemented this to happen specifically right before the
ImportVolumeto guarantee previous functionality on other methods.