Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --kubeconfig option to tridentctl #735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ahothan
Copy link
Contributor

@ahothan ahothan commented Jun 17, 2022

Change description

This PR will add an optional --kubeconfig argument to specify a kubeconfig file to use, similar to kubectl and oc.

Project tracking

see #734)

Do any added TODOs have an issue in the backlog?

N/A

Did you add unit tests? Why not?

No, this only adds one optional argument that is no-op when not specified

Does this code need functional testing?

The changes do not change the main logic of the tridentctl code.
I have tested it using different commands and kubeconfig files and it is working.

Is a code review walkthrough needed? why or why not?

Probably not needed as the changes are relatively simple and only touch a few files

Should additional test coverage be executed in addition to pre-merge?

May require adding test that pass a specific kubeconfig file

Does this code need a note in the changelog?

Yes - same as title of this PR

Does this code require documentation changes?

Yes - self descript line to be added is sufficient as users are already familiar with the argument from using kubectl and oc

Additional Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant